Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show experiment name in the table header #1614

Closed
shcheklein opened this issue Apr 26, 2022 · 7 comments
Closed

Show experiment name in the table header #1614

shcheklein opened this issue Apr 26, 2022 · 7 comments
Assignees
Labels
A: plots Area: plots webview, side panel and everything related enhancement New feature or request priority-p1 Regular product backlog

Comments

@shcheklein
Copy link
Member

When new experiment is running head keeps changing and it's not immediately clear what is going on, neither is not clear when it's done what experiment this column belongs to:

Screen Shot 2022-04-25 at 5 48 54 PM

It should have [exp-fac0a] or something similar.

@shcheklein shcheklein added enhancement New feature or request A: plots Area: plots webview, side panel and everything related labels Apr 26, 2022
@shcheklein shcheklein added the priority-p1 Regular product backlog label May 4, 2022
@shcheklein
Copy link
Member Author

It applies to all other places where we show hashes. W/o seeing names it's extremely hard to navigate.

@mattseddon
Copy link
Member

For this do we want to break away from what is shown in the experiments table and show the experiment name for all checkpoints?

image

Or do we want to add the same information just for the checkpoint_tip / experiment record?

@wolmir
Copy link
Contributor

wolmir commented May 17, 2022

Screen Shot 2022-05-17 at 12 48 19

@shcheklein @mattseddon Something like this, right?

@mattseddon
Copy link
Member

mattseddon commented May 17, 2022

@wolmir, yep that's correct. Left some comments on the PR 👍🏻. Please LMK if they don't make any sense or if you need more context.

Thanks

wolmir added a commit that referenced this issue May 20, 2022
…-header

Show experiment names in comparison table headers (#1614)
@wolmir
Copy link
Contributor

wolmir commented May 20, 2022

@mattseddon @shcheklein I left a comment in the PR, but I just merged it instead.
My question was related to this specific DVC use-case:

When the ML engineer resumes a checkpoint, there is an alternative name to it. It's the short sha of the resumed revision.
This resumed sha is displayed like this (15b7ef1) (for example) besides the checkpoint original revision.
This happens In DVC CLI table and in ours also.

The question: If this happens, is it more valuable to display this resumed revision In the ribbons and other places where the checkpoints are not logically grouped, or is it more valuable to display the experiment name always?

@mattseddon
Copy link
Member

image

For this particular example, my suggestion would be to leave the link to the previous experiment in the table/tree view and use the current experiment name for the plots view (i.e show [exp-3b52b]). Either way is fine though.

@mattseddon
Copy link
Member

OP has been taken care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Area: plots webview, side panel and everything related enhancement New feature or request priority-p1 Regular product backlog
Projects
None yet
Development

No branches or pull requests

3 participants