Show experiment names in comparison table headers (#1614) #1730
Conversation
|
I noticed in the All Small / 1280px Chromatic story that the title text can be line-broken in some situations
Is this something we're okay with, or do we want to do something like truncation to make sure the headers don't get expanded? |
| .experimentName { | ||
| color: $meta-cell-color; | ||
| // font-size: 0.8em; | ||
| // line-height: 0; |
There was a problem hiding this comment.
[I] Let's delete these if we aren't using them.
extension/src/plots/model/index.ts
Outdated
| @@ -177,8 +177,9 @@ export class PlotsModel extends ModelWithPersistence { | |||
| this.comparisonOrder, | |||
| this.experiments | |||
| .getSelectedRevisions() | |||
| .map(({ label: revision, displayColor }) => ({ | |||
| .map(({ label: revision, displayColor, displayNameOrParent }) => ({ | |||
There was a problem hiding this comment.
[C] I asked the question in the ticket as to whether this will be enough (it doesn't provide the name of the experiment if a checkpoint is not the checkpoint_tip i.e the last iteration). We'll need to follow up and add another field to provide the extra information where it is needed.
I think that we will need to display it whenever the checkpoint is shown outside of the logical group. For example in the comparison table. We will also need it when we come to add the new header section in the plots webview:
|
@shcheklein @mattseddon What should be shown in the ribbons? The root name ( |
wolmir
force-pushed
the
show-experiment-name-in-table-header
branch
from
5aed172 to
9c83f25
Compare
wolmir
force-pushed
the
show-experiment-name-in-table-header
branch
from
e5a05e5 to
1f77030
Compare
|
Code Climate has analyzed commit 1f77030 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
For this particular example, my suggestion would be to leave the link to the previous experiment in the table/tree view and use the current experiment name for the plots view (i.e show |
|
|
||
| // if (!experiment) { | ||
| // return | ||
| // } |
This PR will show the
displayNameOrParentproperty of the selected experiment revisions in the comparison table webview when they are available.Issue