Improve plots welcome view when there are no plots #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
add-learning-links
branch
from
8fe9fc1 to
4ad78ca
Compare
|
@mattseddon thanks! can we change links color (they are not readable at this moment), to something like:
|
shcheklein
requested changes
May 16, 2022
mattseddon
commented
May 17, 2022
|
|
||
| &:active { | ||
| color: var(--vscode-textLink-activeForeground); | ||
| } |
There was a problem hiding this comment.
Colors match these docs.
Updated colors for link text globally. |
|
Code Climate has analyzed commit 7510358 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
shcheklein
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up items from #1718
No plots empty state: