Update view container welcome views #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
title-case-empty-view-text
branch
from
8a1c172 to
fc24c8b
Compare
mattseddon
commented
May 17, 2022
| }, | ||
| { | ||
| "view": "dvc.views.experimentsTree", | ||
| "contents": "No experiments to display. \n[Run Experiment](command:dvc.runExperiment)\n" |
There was a problem hiding this comment.
[F] As we now show the workspace and branch this view should never be empty unless something has gone really wrong or the workspace is loading.
|
Code Climate has analyzed commit fc24c8b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
rogermparent
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some inconsistency between the welcome views in the container and the new one in the plots webview when working on #1722.
Demo
Screen.Recording.2022-05-17.at.4.27.43.pm.mov