Fix push/pull directory from DVC tracked tree #1781
Conversation
mattseddon
force-pushed
the
improve-nested-pull-push
branch
2 times, most recently
from
a20c055 to
1cf6754
Compare
| @@ -110,7 +127,7 @@ export class RepositoryModel | |||
| .map(([relativePath, status]) => { | |||
| const absolutePath = this.getAbsolutePath(relativePath) | |||
|
|
|||
| if (!this.state.tracked.has(absolutePath)) { | |||
There was a problem hiding this comment.
[F] No longer can access this.state.tracked directly because it is made up of trackedLeafs and trackedNonLeafs. I have wrapped all access into some helper functions.
There was a problem hiding this comment.
We need to keep this.state.trackedLeafs separately so we can use it in collectTree.
| @@ -1,8 +1,9 @@ | |||
| import { dirname, resolve } from 'path' | |||
| import isEqual from 'lodash.isequal' | |||
| import { dirname, join, resolve } from 'path' | |||
There was a problem hiding this comment.
[F] Whole class (and probably more) will get rewritten when data:status lands.
mattseddon
force-pushed
the
improve-nested-pull-push
branch
from
1cf6754 to
4f175c9
Compare
mattseddon
force-pushed
the
improve-nested-pull-push
branch
from
4f175c9 to
b4268c6
Compare
|
Code Climate has analyzed commit b4268c6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
|
As stated in the description => Will not work as expected without some changes between DVC 2.10.2 and main so we are currently blocked. |
2/3
main<- #1780 <- this <- #1783Relates to iterative/dvc#7756.
This PR fixes out
push/pullactions in the DVC tracked tree by collecting all tracked outs from theexp showdata and feeding that information into the tree for the view.Will not work as expected without some changes between DVC
2.10.2andmainso we are currently blocked.