Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not in cache and deleted decorations for directory contents #1783

Merged
merged 1 commit into from
May 31, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented May 27, 2022

3/3 main <- #1780 <- #1781 <- this

Fixes #1669

#1781 is technically not ready but I wanted to do this before I got out of context over the weekend.

Demo

image

@mattseddon mattseddon added the bug Something isn't working label May 27, 2022
@mattseddon mattseddon self-assigned this May 27, 2022
@mattseddon mattseddon changed the base branch from main to improve-nested-pull-push May 27, 2022 07:45
@mattseddon mattseddon marked this pull request as ready for review May 27, 2022 07:48
@mattseddon mattseddon force-pushed the improve-nested-pull-push branch from d473d2e to c9f555c Compare May 27, 2022 20:03
@mattseddon mattseddon force-pushed the apply-not-in-cache branch 2 times, most recently from 999f4e5 to 07ff585 Compare May 30, 2022 02:59
@mattseddon mattseddon force-pushed the improve-nested-pull-push branch from a20c055 to 1cf6754 Compare May 30, 2022 03:00
@mattseddon mattseddon force-pushed the apply-not-in-cache branch from 07ff585 to 4d15cf2 Compare May 30, 2022 03:00
@mattseddon mattseddon force-pushed the improve-nested-pull-push branch 2 times, most recently from 4f175c9 to b4268c6 Compare May 31, 2022 00:05
@mattseddon mattseddon force-pushed the apply-not-in-cache branch from 4d15cf2 to b196c08 Compare May 31, 2022 00:05
Base automatically changed from improve-nested-pull-push to main May 31, 2022 00:43
@mattseddon mattseddon force-pushed the apply-not-in-cache branch from b196c08 to 8f45da8 Compare May 31, 2022 00:55
@codeclimate
Copy link

codeclimate bot commented May 31, 2022

Code Climate has analyzed commit 8f45da8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon enabled auto-merge (squash) May 31, 2022 00:56
@mattseddon mattseddon merged commit 8de768e into main May 31, 2022
@mattseddon mattseddon deleted the apply-not-in-cache branch May 31, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants