plots: meaningful section default names #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit ddcf582 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
shcheklein
added
product
mattseddon
reviewed
May 30, 2022
| [Section.COMPARISON_TABLE]: 'Comparison' | ||
| [Section.CHECKPOINT_PLOTS]: 'Trends', | ||
| [Section.TEMPLATE_PLOTS]: 'Data Series', | ||
| [Section.COMPARISON_TABLE]: 'Images' |
There was a problem hiding this comment.
[F] These will only update for new users. Anyone who already has the extension installed will stick with the old names.
There was a problem hiding this comment.
We only ever set them when they are undefined as we don't want to overwrite user's custom names for them:
public getSectionName(section: Section): string {
return this.sectionNames[section] || DEFAULT_SECTION_NAMES[section]
}
mattseddon
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in #1635 . It changes sections names to be less confusing and consistent with Studio / DVC docs to:
Data Series,Images,TrendsI'm 100% sure these names are still not self-descriptive and as the next step we need to introduce tooltips.
This is still better, since having
Plotssection in the Plots webview was too strange. AndComparisonwhile describes the table can be applied too all there sections - we are comparing experiments in different ways.We can go and rename all the classes, but to be honest it's not critical and I would wait for a bit until we stabilize all this stuff.