-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meaning of each section in Plots
view.
#1635
Comments
@Davoo the purpose of each section is as follows:
I can see why this can be confusing when we basically have "duplicate" plots across two sections but after the removal of the live section from dvc.yaml there is no longer a reliable way of determining whether or not a DVC project is using DVCLive. If there are duplicates then the user can simply close that section. I can also see why this would be confusing if you are not familiar with the project. It should be noted that you CAN drag and drop plots in the "Plots" and "Experiment Checkpoints" sections: Screen.Recording.2022-05-02.at.9.23.51.am.movBut (to the best of my knowledge) what you are asking for in terms of re-ordering the confusion matrix is not possible. The reason for this is that there is no way to re-order that template plot (I looked into this when trying to keep the order stable on live update). Also if we did this for that one template then I think we would be opening ourselves up to a lot of work trying to cater for every template out there in an ad-hoc manner. Studio considered making this possible by splitting the plot but then they would have ended up with the individual matrices being on different scales which makes them a lot less useful. For that reason they reverted to leaving the plot static and we've followed the approach. Hope this all makes sense. Please LMK if anything is unclear. |
@maxagin, @yalozhkin it would be good to add an on hover or an info button per section to explain the purpose of the section. We do have the info Can we please get a design for this interaction/behaviour. Thanks |
@mattseddon Just an idea. Please let me know how you find it. Thanks I think that if there is something that needs to be explained or clarified it is better to be visible. So here is the concept that reflects this. |
Some subjects from today's discussion are added to the Notion doc. Thank you ! |
@mattseddon if I understand the implementation correctly, this would not only affect DVCLive users but any users logging scalars to both plots and metrics files at each step. Regardless, do you think it would be valuable if DVCLive exposes an env var on instantiation in order to signal that it's being used? |
I think it would be useful but I wouldn't prioritise it. It only solves a very specific edge case at the moment. |
@yalozhkin I remember that we discussed yesterday what would be the names of the sections for now. Please share the mockup if you have it or just the names. Thank you ! |
@mattseddon what is the status of this ticket? Is this idea can be useful #1635 (comment) ? Let me know PL |
The status is that the updated section names and any helper text need to be added to the design shown in this figma. We will then be able to implement that design and close this ticket. |
@maxagin do we need / can we get this spec-ed out before the release? |
Yes @shcheklein we can. |
Hey, guys. I have published the specs. Please let me know if you have any comments or questions. Cheers |
@maxagin spec looks a bit different + comment is off there? (minor things since for this specific spec of course). Also, would it better to use an "i" icon instead - so that these explanation can be hidden for people who understand them already? |
@maxagin I need the actual titles and helper text not placeholder text. @jorgeorpinel can you help out with the exact copy? |
that on me (or @jorgeorpinel can help with that), but let's first agree on the design please |
Also think the text should should not be shown all the time. Once I've read it once I will never want/need to see it again. |
Sorry, can you please clarify what you mean by saying it looks different?
The original concept was more or less like on the attachment. However, what exactly to display will be related to the type of description we want to have. Some information is better to be shown all the time especially if we could have different descriptions.
WDYT? |
If I could see the real description it would help me to make a better decision or have the right arguments. Thanks |
This is what we currently have in the walkthrough for plots: https://github.com/iterative/vscode-dvc/blob/main/extension/resources/walkthrough/plots.md. Note the section names have changed to Data Series, Images & Trends. It is not final but will hopefully help to get you started. |
Hey guys. I have updated the specs with all the changes. Please let me know WDYT. Thanks ! |
Sorry for late reply. I do not have access to this. Please share to jorge@iterative.ai . Thanks |
@jorgeorpinel see and review the text here please #1851 |
I don't fully understand the purposes of each section. Maybe we could have a tooltip explaining?
Figma specs
From the demo project:
Plots
I see
predictions.json
andtraining_metrics
for all revisions.Comparison
I see
misclassified.jpg
so I assume this is for logged images?The UI appears different, I can drag and drop revisions but this is not available in the
Plots
section (i.e. I would like to be able to reorder the confusion matrix like I reorder the image)Experiment checkpoints
I see the same content as
Plots
but with different axis labels and without the workspace and main revisions.The text was updated successfully, but these errors were encountered: