Add tooltip with the meaning of each plot section #1851
Conversation
sroy3
requested review from
mattseddon,
rogermparent,
maxagin,
shcheklein and
wolmir
|
Very nice @sroy3! Minor: the icon sims a bit off - not centred vertically |
You're right. I added a wrapper to make the tooltip work and it skewed the vertical alignment. I fixed it now: |
It's possible, but I'd have to tweak the behaviour of the tooltip a bit so it doesn't close automatically on mouse leave (it's something that's possible with the |
|
Code Climate has analyzed commit 090894b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
| [Section.TEMPLATE_PLOTS]: | ||
| 'JSON, YAML, CSV or TSV files visualized using Vega pre-defined or custom Vega-Lite templates.' |
There was a problem hiding this comment.
Are users expected to know what Vega is?
There was a problem hiding this comment.
No, if we have time it's better to review and change this text.
There was a problem hiding this comment.
And other plot section descriptions, I've done this in the walkthrough.
There was a problem hiding this comment.
For #1635
Screen.Recording.2022-06-07.at.10.35.38.AM.mov