Add position:sticky to Experiment table head #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogermparent
added
A: experiments
rogermparent
changed the title
rogermparent
commented
Jun 1, 2022
| position: sticky; | ||
| top: 0; | ||
| z-index: 3; | ||
| background-color: $bg-color; |
There was a problem hiding this comment.
This keeps the right border of the table body from overlapping with the head
sroy3
approved these changes
Jun 1, 2022
mattseddon
approved these changes
Jun 2, 2022
shcheklein
approved these changes
Jun 2, 2022
|
Thanks @rogermparent for addressing this. Agreed with @mattseddon and one more next step is to add a bit of shadow if possible / if it makes sense (when some content is hidden). But definitely let's merge this! |
|
Code Climate has analyzed commit 6138da2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple implementation of a sticky header using CSS
position: stickyto implement it.sticky-header-demo.mp4
The style is currently imperfect, particularly on the right-hand side when the table doesn't expand to the full width horizontally. Ther e is also currently no shadow added when scrolling.
I first tried to use a Flexbox-based solution thinking it more proper as we've had some trouble with
position:stickyon websites, but the flex implementation took a lot of wrestling with the table widths and ended up being less user-friendly as horizontal scrolling became more difficult in a vertical-scroll-only body.Relates to #1562