Make Experiments Table Experiments Column Sticky #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogermparent
force-pushed
the
sticky-exp-column
branch
from
1fed1fd to
62a4283
Compare
rogermparent
added
A: experiments
rogermparent
changed the title
mattseddon
approved these changes
Jun 2, 2022
shcheklein
approved these changes
Jun 2, 2022
|
Looks good to me. Again, as a followup we can try to add shadow (let's create a ticket for this?), but it solves the problem as-is. |
|
Code Climate has analyzed commit b8d9dc3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
|
Follow up ticket on shadows: #1826 |
We have it here (Phase 1) : #1562 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the first "Experiment" column in the experiments table sticky, such that it will always be present even when scrolling to the right. This, like #1805, is also implemented with
position: sticky.Some styles had to be reworked in order to make things not look broken, particularly adding backgrounds to elements to things wouldn't show up behind them as well as changing the left and right borders of rows to be applied to the first and last cell instead of the row itself.
sticky-experiments-column-demo.mp4