Add multi-select push and pull to tracked explorer tree #1809
Conversation
| ): TreeView<string | T> => | ||
| window.createTreeView<string | T>(name, { | ||
| canSelectMany: false, | ||
| canSelectMany, |
There was a problem hiding this comment.
Here is a lie from the VS Code API docs:
There was a problem hiding this comment.
Because this doesn't work I have used the tree's selection property.
extension/src/fileSystem/tree.ts
Outdated
| } | ||
|
|
||
| private getSelectedPathItems() { | ||
| return [...this.treeView.selection] |
There was a problem hiding this comment.
[F] We can use a similar approach to delete multiple experiments from the experiments tree.
| const acc = [] | ||
| const acc: string[] = [] | ||
| if (typeof pathItem === 'string') { | ||
| return acc |
There was a problem hiding this comment.
[F] If we try to pull the root then just run dvc pull with the root as the cwd.
|
Seems that this breaks single-item pulls as well as the pull button in the SCM tree. single-pull-broken-demo.mp4 |
I will fix. |
mattseddon
force-pushed
the
add-multi-select-push-pull
branch
from
ad29a7f to
57d1fa8
Compare
@rogermparent I completely forgot that the SCM view is tied to this command so thanks. There is some history in how the commands have evolved over the life course of the codebase. Initially the commands were built specifically for the SCM view. They've been moved around, patched, and updated so many times that they are unrecognizable from the initial intended use. With all that said the easiest thing to do (for now) is to add some extra information to the SCM tree and call the same command. I still intend to rip this out/up once we get the new DemoScreen.Recording.2022-06-02.at.3.08.57.pm.movScreen.Recording.2022-06-02.at.3.09.48.pm.mov |
I think as long as all the features work in a basic sense, we're good to go 👍 |
mattseddon
force-pushed
the
add-multi-select-push-pull
branch
from
4d9f85b to
569523d
Compare
|
Code Climate has analyzed commit 569523d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 96.7% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.9% (0.1% change). View more on Code Climate. |
1/2
main<- this <- #1810Closes #1668.
This PR adds multi-select push/pull actions to the tracked explorer tree.
Demo
Screen.Recording.2022-06-01.at.3.59.22.pm.mov
Note: Once we bump the min version of DVC the number of files being pulled should be reduced as the
exp showbut will be squashed.