Watch all dvc.yamls for changes to plots #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
watch-dvc-yaml-for-plots-changes
branch
from
27f588f to
5c0f161
Compare
|
Code Climate has analyzed commit 5c0f161 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
sroy3
approved these changes
Jun 2, 2022
This was referenced Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1797.
I did not setup the scenario correctly when I previously tried to fix this issue. If there are actually no plots on the checked-out branch then no paths are being watched. This meant that the watcher did not fire when moving back to
main/a branch that has plots. Watching alldvc.yamls for changes will actually fix the issue and will fix another issue for new projects without plots as well.Demo
Screen.Recording.2022-06-03.at.5.29.07.am.mov