Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch all dvc.locks for changes to plots #1840

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jun 6, 2022

Follow up from #1822 as it did not fix the OP.

For the record: dvc.lock file(s) can/will/should change without any dvc.yaml(s) changing so this gives us coverage of more scenarios.

@mattseddon mattseddon added the bug Something isn't working label Jun 6, 2022
@mattseddon mattseddon self-assigned this Jun 6, 2022
@mattseddon mattseddon marked this pull request as ready for review June 6, 2022 09:46
@mattseddon mattseddon enabled auto-merge (squash) June 6, 2022 18:05
@mattseddon mattseddon disabled auto-merge June 6, 2022 18:05
@codeclimate
Copy link

codeclimate bot commented Jun 6, 2022

Code Climate has analyzed commit 0a63758 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.9% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 5a26279 into main Jun 6, 2022
@mattseddon mattseddon deleted the add-dvc-lock-to-watcher branch June 6, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants