Show plots errors in plots tree #3522
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| import { ErrorDecorationProvider } from '../../tree/errorDecorationProvider' | ||
| import { uniqueValues } from '../../util/array' | ||
|
|
||
| export class DecorationProvider extends ErrorDecorationProvider { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
There was a problem hiding this comment.
This is identical to extension/src/repository/model/decorationProvider.ts and close to extension/src/experiments/model/decorationProvider.ts I can follow up.
mattseddon
force-pushed
the
use-errors
branch
3 times, most recently
from
d627859 to
f2eda8c
Compare
mattseddon
force-pushed
the
show-tree-errors
branch
from
9d07c0b to
e7c905f
Compare
mattseddon
force-pushed
the
show-tree-errors
branch
from
e7c905f to
4f4f31e
Compare
|
Note: there is a bug where SCM file decorations can run into the plots tree. I should be able to stop this from happening but it will require a workaround. E.g
|
mattseddon
force-pushed
the
show-tree-errors
branch
from
4f4f31e to
ae197a0
Compare
| @@ -90,6 +92,9 @@ export abstract class BasePathSelectionTree< | |||
| if (description) { | |||
| treeItem.description = description | |||
| } | |||
| if (tooltip) { | |||
| treeItem.tooltip = tooltip | |||
There was a problem hiding this comment.
What's the point of checking for the element before assigning it? If tooltip is undefined, treeItem.tooltip is undefined as well anyway, no? I'm asking because I'm probably missing something.
There was a problem hiding this comment.
you are right, there is no point. I'll update
mattseddon
force-pushed
the
show-tree-errors
branch
from
ae197a0 to
a7f586f
Compare
mattseddon
force-pushed
the
show-tree-errors
branch
from
a7f586f to
e560f67
Compare
mattseddon
force-pushed
the
show-tree-errors
branch
from
e560f67 to
82fa5b4
Compare
|
Code Climate has analyzed commit 82fa5b4 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 90.5% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
3/4
main<- #3477 <- #3520 <- this <- #3532Relates to #2277
Demo
Screen.Recording.2023-03-21.at.7.21.53.pm.mov
Note: The above shows that I need to add the "full update" logic for when the dvc.yaml is changed (will be done in #3532).