Ensure unfetched image plots are on disk before providing URL to webview #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
ensure-image-on-disk
branch
from
1ed030d to
ff2489c
Compare
This was referenced Mar 24, 2023
mattseddon
force-pushed
the
drop-cache-on-update
branch
from
02b01cc to
e1519ad
Compare
mattseddon
force-pushed
the
ensure-image-on-disk
branch
from
ff2489c to
9efc4ac
Compare
mattseddon
force-pushed
the
drop-cache-on-update
branch
from
e1519ad to
b0dd757
Compare
mattseddon
force-pushed
the
ensure-image-on-disk
branch
from
9efc4ac to
8b6f317
Compare
This was referenced Mar 24, 2023
sroy3
approved these changes
Mar 24, 2023
julieg18
approved these changes
Mar 24, 2023
mattseddon
force-pushed
the
drop-cache-on-update
branch
2 times, most recently
from
72be7b6 to
02e94b4
Compare
mattseddon
force-pushed
the
ensure-image-on-disk
branch
from
8b6f317 to
8a7340d
Compare
|
Code Climate has analyzed commit a22dc14 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5/9
main<- #3477 <- #3520 <- #3522 <- #3532 <- this <- #3545 <- #3546 <- #3547 <- #3548We "shouldn't" ever get into this situation but I have seen some weirdness whilst testing the new logic. Seemed like a good idea to make sure the error can't happen.
Also took the opportunity to centralise more collection logic in the extension.