Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pausing of data updates when running/queueing experiments #3815

Merged
merged 2 commits into from
May 3, 2023

Conversation

mattseddon
Copy link
Contributor

@mattseddon mattseddon commented May 3, 2023

Related to #3178

Back in #1123 I added code to pause data updates whilst we queue experiments. This was because the commands used to update the data would take the read/write lock on the repository and cause the queueing process to fail. Now these commands are lockless so we don't need to pause updates anymore. The same thing happened intermittently when we started running experiments.

We need to do this to avoid trying to provide progress updates for batch-queueing experiments - e.g a grid search (see #3814)

Demo

Screen.Recording.2023-05-03.at.1.52.24.pm.mov

@mattseddon mattseddon added the product PR that affects product label May 3, 2023
@mattseddon mattseddon self-assigned this May 3, 2023
@mattseddon mattseddon marked this pull request as ready for review May 3, 2023 03:53
@mattseddon mattseddon requested review from sroy3 and julieg18 as code owners May 3, 2023 03:53
@mattseddon mattseddon requested a review from shcheklein May 3, 2023 03:55
@shcheklein
Copy link
Member

so, queueing is immediate? we were slowing it down artificially by running some commands?

@mattseddon
Copy link
Contributor Author

mattseddon commented May 3, 2023

so, queueing is immediate? we were slowing it down artificially by running some commands?

When we queued a big batch of experiments the functions that update the data underlying the table (that call exp show) were paused. We waited for the entire command to complete before unpausing them.

The same thing didn't happen for running experiments as they get processed asynchronously. For those we would start the experiment and then unpause updates.

Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon mattseddon enabled auto-merge (squash) May 3, 2023 19:21
@codeclimate
Copy link

codeclimate bot commented May 3, 2023

Code Climate has analyzed commit 2e2d864 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 90.9% (85% is the threshold).

This pull request will bring the total coverage in the repository to 94.7% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit c442123 into main May 3, 2023
@mattseddon mattseddon deleted the remove-update-pause branch May 3, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants