Remove pausing of data updates when running/queueing experiments #3815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3178
Back in #1123 I added code to pause data updates whilst we queue experiments. This was because the commands used to update the data would take the read/write lock on the repository and cause the queueing process to fail. Now these commands are lockless so we don't need to pause updates anymore. The same thing happened intermittently when we started running experiments.
We need to do this to avoid trying to provide progress updates for batch-queueing experiments - e.g a grid search (see #3814)
Demo
Screen.Recording.2023-05-03.at.1.52.24.pm.mov