Add ability to pause data updates #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -177,11 +177,16 @@ export class WorkspaceExperiments extends BaseWorkspaceWebviews< | |||
| } | |||
| } | |||
|
|
|||
| public createRepository(dvcRoot: string, resourceLocator: ResourceLocator) { | |||
| public createRepository( | |||
There was a problem hiding this comment.
Function createRepository has 26 lines of code (exceeds 25 allowed). Consider refactoring.
mattseddon
force-pushed
the
pause-updates
branch
from
485dad4 to
c4ef586
Compare
mattseddon
changed the base branch from
nest-repo-files
to
remove-unnecessary-emitter
mattseddon
commented
Dec 6, 2021
| @@ -1,3 +1,4 @@ | |||
| import { EventEmitter } from 'vscode' | |||
There was a problem hiding this comment.
[F] These are the functional changes and the corresponding test is here.
There was a problem hiding this comment.
The rest is just EventEmitter drilling and signature changes.
mattseddon
force-pushed
the
remove-unnecessary-emitter
branch
from
dc90c83 to
a7969dd
Compare
mattseddon
force-pushed
the
pause-updates
branch
from
c4ef586 to
058d5f2
Compare
This was referenced Dec 6, 2021
sroy3
approved these changes
Dec 6, 2021
rogermparent
approved these changes
Dec 6, 2021
mattseddon
force-pushed
the
remove-unnecessary-emitter
branch
from
a7969dd to
55ee93f
Compare
mattseddon
force-pushed
the
pause-updates
branch
from
058d5f2 to
211138d
Compare
|
Code Climate has analyzed commit 211138d and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4/5
master<- #1120 <- #1122 <- #1124 <- this <- #1125Follow up from https://github.com/iterative/vscode-dvc/pull/1120/files#r762631396 i.e the "temporary fix" (
waitForLock) which was implemented so that we could queue experiments without error because they were running into the locks created bystatus,diff,exp show, etc.This will mitigate the issue of updates running whenever we perform an action running within the extension but there is nothing that comes to mind for something that we can do about updates running when a user uses the CLI directly.
Also relates to #948 (comment).