Pause data updates while we queue experiments #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
pause-updates-for-queue
branch
from
788aa70 to
e067082
Compare
This was referenced Dec 6, 2021
mattseddon
changed the title
mattseddon
force-pushed
the
pause-updates-for-queue
branch
from
22b9c23 to
7e52ce8
Compare
sroy3
approved these changes
Dec 6, 2021
rogermparent
approved these changes
Dec 6, 2021
mattseddon
force-pushed
the
pause-updates
branch
from
058d5f2 to
211138d
Compare
… pause-updates-for-queue
mattseddon
force-pushed
the
pause-updates-for-queue
branch
from
7e52ce8 to
e345b7a
Compare
|
Code Climate has analyzed commit e345b7a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 92.3% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5/5
master<- #1120 <- #1122 <- #1124 <- #1123 <- thisThis PR pauses all data updates while we queue any experiments. It also adds a
forceRunQueuedmethod to theProcessManagerwhich can be used to manually force a data update for experiments. We need to put this in so that we can provide the user with "status" updates as the experiments are being queued. This does make things a bit slower but we would be able to improve the flow ifexp showever became lockless.Demo
Screen.Recording.2021-12-06.at.4.21.09.pm.mov