Remove unnecessary event emitter / event chain in Repository #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Dec 6, 2021
| @@ -114,7 +114,7 @@ export class DecorationProvider implements FileDecorationProvider { | |||
| } | |||
| } | |||
|
|
|||
| public setState = (state: DecorationState) => { | |||
There was a problem hiding this comment.
[F] Can't spy on the prototype if you use an arrow function.
This was referenced Dec 6, 2021
mattseddon
force-pushed
the
nest-repo-files
branch
from
d23d905 to
ec4e52f
Compare
mattseddon
force-pushed
the
remove-unnecessary-emitter
branch
from
dc90c83 to
a7969dd
Compare
This was referenced Dec 6, 2021
sroy3
approved these changes
Dec 6, 2021
rogermparent
approved these changes
Dec 6, 2021
mattseddon
force-pushed
the
nest-repo-files
branch
from
ec4e52f to
138b23b
Compare
mattseddon
force-pushed
the
remove-unnecessary-emitter
branch
from
a7969dd to
55ee93f
Compare
|
Code Climate has analyzed commit 55ee93f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (-0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3/5
master<- #1120 <- #1122 <- this <- #1123 <- #1125Noticed this when preparing #1123. I had used a different
treeDataChangedEventEmitters between theRepositoryandWorkspaceRepositoriesclasses. I think the original reason for doing this would have been something to do with testing but we haven't used theRepository.onDidChangeTreeDataevent anywhere so it can be removed.