Adjust plot ribbon tooltips #4135
Conversation
* remove Created column * add table description
| @@ -42,6 +42,9 @@ export const RibbonBlockTooltip: React.FC<{ | |||
| ))} | |||
| </tbody> | |||
| </table> | |||
| <p className={styles.tooltipTableDescription}> | |||
| *Reflects the first three columns (minus Created) in the table | |||
There was a problem hiding this comment.
*Reflects the first three columns (minus Created) in the table
- Could swap
*with another info icon. - Change
minustoexcluding. - Need to mention that it is the experiments table.
- Give instructions on how to update. Something like "Drag and drop columns to the start of the table to update.
This could also go after the commit information.
I'm almost tempted to suggest turning the ribbon into a mini version of the table that always displays the selected columns but I think that is a story in itself.
There was a problem hiding this comment.
Need to mention that it is the experiments table.
Change minus to excluding.
👍
Give instructions on how to update. Something like "Drag and drop columns to the start of the table to update.
I considered that but didn't want to make the message too verbose since it's already rather lengthy... I'll post an image and see what others think though.
Could swap * with another info icon.
Good idea, I'll try it and see how it looks!
This could also go after the commit information.
Why would we want to move the table below the commit information? I figured that the table information is more important than the commit hence why it's first 🤔
There was a problem hiding this comment.
Here's what it looks like with extra instructions:
What do we think? Plus, do we need additional instructions or is it obvious enough that a user can move columns once they start to work with the table?
Though I suppose if we increase the table rows, the extra text length would look better 🤔
|
Code Climate has analyzed commit 56e2144 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
Demo
https://github.com/iterative/vscode-dvc/assets/43496356/f2c24368-d01f-4064-a18b-1c6c4c41f201Screen.Recording.2023-06-20.at.10.54.01.AM.mov
Fixes #3942