Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use first three metrics and params in table tooltips & quick picks #4155

Merged
merged 8 commits into from
Jun 23, 2023

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Jun 20, 2023

1/2 main <= this <= #4159

Demo

Screen.Recording.2023-06-23.at.10.11.35.AM.mov

Followup to #4135 (review)

@julieg18 julieg18 added the product PR that affects product label Jun 20, 2023
@julieg18 julieg18 self-assigned this Jun 20, 2023
@julieg18 julieg18 requested a review from mattseddon June 20, 2023 18:04
label: 'main',
value: 'main'
},
{
description: '[exp-e7a67]',
detail: 'loss:2.0205045, accuracy:0.37241668, val_loss:1.9979371',
detail:
'code_names:[0,1], epochs:2, learning_rate:2e-12, loss:2.0205045, accuracy:0.37241668, val_loss:1.9979371',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is using six column values too lengthy for the quick pick?

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think it is fine.

@julieg18 julieg18 marked this pull request as ready for review June 21, 2023 15:53
@julieg18 julieg18 requested a review from sroy3 as a code owner June 21, 2023 15:53
@julieg18 julieg18 requested a review from shcheklein June 21, 2023 15:54
extension/src/experiments/columns/model.test.ts Outdated Show resolved Hide resolved
extension/src/experiments/columns/model.ts Outdated Show resolved Hide resolved
extension/src/experiments/columns/model.ts Outdated Show resolved Hide resolved
label: 'main',
value: 'main'
},
{
description: '[exp-e7a67]',
detail: 'loss:2.0205045, accuracy:0.37241668, val_loss:1.9979371',
detail:
'code_names:[0,1], epochs:2, learning_rate:2e-12, loss:2.0205045, accuracy:0.37241668, val_loss:1.9979371',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think it is fine.

webview/src/plots/components/ribbon/RibbonBlockTooltip.tsx Outdated Show resolved Hide resolved
@julieg18 julieg18 enabled auto-merge (squash) June 23, 2023 15:28
@julieg18 julieg18 changed the title Use first three metrics and params in table tooltips Use first three metrics and params in table tooltips & quick picks Jun 23, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 23, 2023

Code Climate has analyzed commit 1dfff91 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.2% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 merged commit ac0cc7e into main Jun 23, 2023
@julieg18 julieg18 deleted the use-metrics-and-params-in-table-tooltips branch June 23, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants