Ensure experiment summary info (columns) is always available in the experiment table data #4396
Conversation
| @@ -197,12 +172,18 @@ export class ColumnsModel extends PathSelectionModel<Column> { | |||
|
|
|||
| this.data = columns | |||
|
|
|||
| if (this.columnOrderState.length === 0) { | |||
There was a problem hiding this comment.
[B] If this.columnOrderState.length > 0 but columnOrderState does not contain the current params and metrics then getSummaryColumnOrder gives unexpected results.
There was a problem hiding this comment.
This is actually still the case because there can be stale data in the status object. I will make an update. I have also updated the status object to drop selected columns that are no longer present in the data. These items will be re-added as selected if they ever reappear.
mattseddon
force-pushed
the
fix-column-order
branch
3 times, most recently
from
5b2a75e to
5acf18a
Compare
mattseddon
changed the title
mattseddon
force-pushed
the
fix-column-order
branch
from
5acf18a to
cfb8519
Compare
…xperiment table data
mattseddon
force-pushed
the
fix-column-order
branch
from
cfb8519 to
a2b7309
Compare
|
Code Climate has analyzed commit a2b7309 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
When looking at tooltips for #4229 I found multiple ways to completely break the tooltips by having the columnOrder out of sync with the data in the table. Previously the only way to fix this was by moving a column. This PR should close the loop.