Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show only changed behaviour #4512

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Fix show only changed behaviour #4512

merged 1 commit into from
Aug 16, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Aug 16, 2023

Use of memo introduced in #4503 broke show only changed.

main

Screen.Recording.2023-08-16.at.4.36.10.pm.mov

PR

Screen.Recording.2023-08-16.at.4.35.26.pm.mov

@mattseddon mattseddon added the bug Something isn't working label Aug 16, 2023
@mattseddon mattseddon self-assigned this Aug 16, 2023
@mattseddon mattseddon marked this pull request as ready for review August 16, 2023 06:39
@@ -28,7 +28,7 @@ interface TableHeadProps {
setTableHeadHeight: (height: number) => void
}

const THead = ({
export const TableHead = ({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function TableHead has a Cognitive Complexity of 10 (exceeds 6 allowed). Consider refactoring.

}): JSX.Element => {
export const TableRow: React.FC<
RowProp & { className?: string; isExpanded: boolean }
> = ({ row, isExpanded, className }): JSX.Element => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function TableRow has a Cognitive Complexity of 10 (exceeds 6 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Aug 16, 2023

Code Climate has analyzed commit 4bc7a44 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.2% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 6b1e86f into main Aug 16, 2023
@mattseddon mattseddon deleted the remove-use-of-memo branch August 16, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant