Group files around concepts #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| import { quickPickValue } from '../../vscode/quickPick' | ||
| import { ParamOrMetric } from '../webview/contract' | ||
|
|
||
| export const pickFromParamsAndMetrics = ( |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
This was referenced Jul 28, 2021
Merged
mattseddon
commented
Jul 28, 2021
| @@ -504,17 +504,17 @@ | |||
| "view/title": [ | |||
| { | |||
| "command": "dvc.runExperiment", | |||
| "when": "view == dvc.views.experimentsRunsTree", | |||
| "when": "view == dvc.views.experimentsTree", | |||
There was a problem hiding this comment.
[F] With the new placement this name actually makes sense now
mattseddon
commented
Jul 28, 2021
| @@ -0,0 +1,189 @@ | |||
| import { join } from 'path' | |||
There was a problem hiding this comment.
[F] These tests are just lifted from the original quickPick test file
…rams-and-metrics-model
…vscode-dvc into split-experiments-model
…-dvc into rename-legacy-variables
…-dvc into group-files-around-concepts
…iles-around-concepts
rogermparent
approved these changes
Jul 28, 2021
|
Code Climate has analyzed commit 4118eda and detected 6 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6/6
master<- #689 <- #690 <- #691 <- #692 <- #693 <- thisThis PR groups files around concepts instead of function.
We now have the following folder structure:
In order to get here I've split the existing
extension/src/experiments/quickPick.tsinto its component parts and moved the respective tree views. I have also renamed theRunstree to simplyExperimentsas per the existing design.I realise that this is a big change and it would be pretty difficult to integrate with #687. I'm happy to hold off merging until after that PR has gone in. Also happy to head in a different direction if you have any other ideas. LMK what you think.