Switch ExperimentsParamsAndMetricsTree to string | ParamsAndMetricsItem tree type
#700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
mattseddon
changed the title
ExperimentsParamsAndMetricsTree to string | ParamsAndMetricsItem tree type
|
Code Climate has analyzed commit acffc32 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.3% (0.0% change). View more on Code Climate. |
rogermparent
approved these changes
Aug 3, 2021
rogermparent
pushed a commit
that referenced
this pull request
Aug 3, 2021
…Item tree type (#700) * move params and metrics tree to mixed type * remove get param or metric methods where possible * rework tree data type * improve test * improve test variable names
mattseddon
added a commit
that referenced
this pull request
Aug 11, 2021
* Get sortBy tree to the point where it displays sorts * Adapt to renamed field * Big refactor - Split getChildren branches into methods - Await experiments for root - Turn getSort into getSorts (multi sorts not actually implemented) * Sort sortByTree roots like paramsAndMetricsTree roots * Add contextValue to TreeItems * Remove accidentally merged file * Revert file accidentally changed by merge * Add commands to tree title and add tests * Build mocked TreeItem that uses contructor * Remove double mocks * Remove unused mocks * Prefix TreeItem contextValues with dvc * Rename clearSort to clearSorts * Add multi-sort capability to sort function * More multi-sort support with test for sort function * Add another test * Add multi-sort functionality * Fix integration test * add windows hide option for windows users (#701) * Switch `ExperimentsParamsAndMetricsTree` to string | ParamsAndMetricsItem tree type (#700) * move params and metrics tree to mixed type * remove get param or metric methods where possible * rework tree data type * improve test * improve test variable names * Add createTreeView wrapper (#703) * move params and metrics tree to mixed type * remove get param or metric methods where possible * rework tree data type * improve test * improve test variable names * add create tree view wrapper Co-authored-by: rogermparent <rogermparent@gmail.com> * add notes on disabling cli analytics to help performance (#699) Co-authored-by: Roger <rogermparent@gmail.com> * Add basic integration test and make sortBy non-mutating * Add multi-sort to sorts integration test * Add single sort removal to integration test * Use removeAllSorts for final clear * Add repo-level addSort and rework data piping so await works for it * Add "all items are equal" test for multi-sort * Add sort modification to integration test * Return this.notifyChanged again to simplify diff * clearExperimentsTableSort -> removeExperimentsTableSorts * Rename a few commands and combine removeSorts commands * Display empty array when there are are projects but no sorts * Use createTreeView utility * Change pluckTestParams inline helper to be a no-arg function * Trim back sort integration test data to only params * Rename command strings and remove unused ones * Combine add and remove sort commands * Swap removeSort params and use getRepository * import { join } from 'path' * interface SortDefinitionWithParent => type SortItem * build => pick and simplify buildExperimentSortFunction * Inline pickSort into experiments repository class, can => should * Remove getOrPickRepo and change removeSorts behavior to be like filters * Add another entry to integration test data Co-authored-by: mattseddon <37993418+mattseddon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/2
master<- this <- #703This PR brings the data held inside of the
ExperimentsParamsAndMetricsTreein line with the new format for our treeViews.Note: My opinion now is that having more data in the tree makes them harder to test and I am concerned that by having more data exposed in more places that we could run into state issues.