Add plots show command (with stub) #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Nov 4, 2021
extension/src/cli/reader.test.ts
Outdated
| @@ -8,6 +8,7 @@ import { createProcess } from '../processExecution' | |||
| import { getFailingMockedProcess, getMockedProcess } from '../test/util/jest' | |||
| import { getProcessEnv } from '../env' | |||
| import complexExperimentsOutput from '../test/fixtures/complex-output-example' | |||
There was a problem hiding this comment.
This file needs to be renamed
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
mattseddon
commented
Nov 4, 2021
|
|
||
| const plots = await cliReader.plotsShow(cwd) | ||
| expect(plots).toEqual(complexStaticPlots) | ||
| expect(mockedCreateProcess).not.toBeCalled() |
There was a problem hiding this comment.
[F] This second expect will fail when we remove the stub, we can then replace it with whats below
mattseddon
commented
Nov 4, 2021
| @@ -172,6 +182,11 @@ export class CliReader extends Cli { | |||
| formatter: typeof trimAndSplit | typeof JSON.parse, | |||
| ...args: Args | |||
| ): Promise<T> { | |||
| // Stubbed until DVC ready | |||
| if (isEqual(args, ['plots', 'show', '--show-json'])) { | |||
There was a problem hiding this comment.
[F] This is a guess at what the command will actually be
mattseddon
force-pushed
the
add-static-plots
branch
2 times, most recently
from
2df8d38 to
6b4b10b
Compare
mattseddon
commented
Nov 4, 2021
| @@ -173,7 +175,7 @@ const data = { | |||
| ] | |||
| } | |||
| ] | |||
| }, | |||
| } as VisualizationSpec, | |||
There was a problem hiding this comment.
[F] Have to cast otherwise we get type errors
mattseddon
commented
Nov 4, 2021
| @@ -986,6 +986,7 @@ | |||
| "@types/lodash.omit": "^4.5.6", | |||
| "@types/mocha": "^8.2.0", | |||
| "@types/node": "^14.14.22", | |||
| "@types/react-vega": "^7.0.0", | |||
There was a problem hiding this comment.
[F] We need this for the contract
mattseddon
force-pushed
the
rename-test-fixtures
branch
from
62010d6 to
f3392c0
Compare
mattseddon
force-pushed
the
add-static-plots
branch
from
6b4b10b to
20a17eb
Compare
This was referenced Nov 5, 2021
rogermparent
approved these changes
Nov 5, 2021
|
Code Climate has analyzed commit 625ff96 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.3% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/5
master<- #1001 <- this <- #996 <- #998 <- #999This PR adds a stub for
plots show --show-jsonwhich I use in the subsequent PRs to wire up the first iteration of displaying static plots in the new plots webview.In the final PR the stub is changed from the test fixture to
{}so that we do not display any of the stubbed data to any users.There will no doubt be conflicts with
masterin #999 because of the work coming in from #1000. Happy to fix them after the fact 👍🏻 .