Update plots types to accomodate static plot data #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
mattseddon
force-pushed
the
add-plots-data-management
branch
from
89f750b to
a0b2cee
Compare
mattseddon
force-pushed
the
update-types-for-new-data
branch
from
db0de62 to
1097b0e
Compare
mattseddon
commented
Nov 5, 2021
| return this.experiments?.getLivePlots() || [] | ||
| return { | ||
| live: this.experiments?.getLivePlots() || [], | ||
| static: this.staticPlots |
There was a problem hiding this comment.
[F] We are going to have to rethink this if we don't want to hold a copy of the static plots data in the extension.
mattseddon
force-pushed
the
add-plots-data-management
branch
from
a0b2cee to
40cd0f0
Compare
mattseddon
force-pushed
the
update-types-for-new-data
branch
from
4d0b70a to
86e6918
Compare
This was referenced Nov 5, 2021
mattseddon
commented
Nov 5, 2021
mattseddon
commented
Nov 5, 2021
| Array.isArray(data) && | ||
| (data.length === 0 || (data[0].title && data[0].values)) | ||
| ) | ||
| return !!(hasKey(data, 'live') && hasKey(data, 'static')) |
There was a problem hiding this comment.
[F] Deferring this decision until we have more information as to what a valid state for the plots webview is.
mattseddon
commented
Nov 5, 2021
| @@ -113,7 +113,7 @@ const Plot = ({ | |||
| const Plots = ({ plotsData }: { plotsData?: PlotsData }) => { | |||
| return ( | |||
| <> | |||
| {plotsData?.map(plotData => ( | |||
| {plotsData?.live?.map(plotData => ( | |||
There was a problem hiding this comment.
Will conflict with #1000
rogermparent
approved these changes
Nov 5, 2021
…types-for-new-data
|
Code Climate has analyzed commit d7448f6 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.3% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4/5 master <- #1001 <- #995 <- #996 <- this <- #999
This PR updates the
PlotsDatatype to accommodate static plots being sent to the webview.