Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency of Haskell code style - replace tabs with spaces #205

Closed
ivanperez-keera opened this issue May 14, 2022 · 0 comments
Closed

Consistency of Haskell code style - replace tabs with spaces #205

ivanperez-keera opened this issue May 14, 2022 · 0 comments
Assignees
@ivanperez-keera
Labels
maintenance
Milestone
Yampa 0.13.5

Comments

@ivanperez-keera
Copy link
Owner

ivanperez-keera commented May 14, 2022 •
edited
Loading

A number of optional style suggestions were not implemented in #200 (see #200 (comment)).

Several files contain tabs, which are not allowed as per our style guide. They should be replaced with spaces.
@ivanperez-keera ivanperez-keera added this to the (+1) milestone May 14, 2022
@ivanperez-keera ivanperez-keera self-assigned this May 14, 2022
@ivanperez-keera ivanperez-keera changed the title Consistency of Haskell code style - removing commented code/notes/todos Consistency of Haskell code style - replace tabs with spaces May 14, 2022
ivanperez-keera added a commit that referenced this issue May 14, 2022
@ivanperez-keera
yampa: Replace tabs with spaces in all examples (KSG Haskell 1.3.0 - …
42ef745 
…2.2.1). Refs #205.

As per our own style guide, tabs are not allowed anywhere in files.

This commit replaces all tabs in all examples with 8 spaces.
ivanperez-keera added a commit that referenced this issue May 14, 2022
@ivanperez-keera
yampa-test: Replace tabs with spaces (KSG Haskell 1.3.0 - 2.2.1). Refs …
66f1a77 
…#205.

As per our own style guide, tabs are not allowed anywhere in files.

This commit replaces all tabs in all tests with 8 spaces.
ivanperez-keera added a commit that referenced this issue May 14, 2022
@ivanperez-keera
Document changes in yampa:CHANGELOG. Refs #205.
096abd4
ivanperez-keera added a commit that referenced this issue May 14, 2022
@ivanperez-keera
Document changes in yampa-test:CHANGELOG. Refs #205.
cf7ba37
@ivanperez-keera ivanperez-keera mentioned this issue May 14, 2022
Closed
ivanperez-keera added a commit that referenced this issue May 14, 2022
@ivanperez-keera
yampa-test: Remove local GHC option disable warnings for tabs. Refs #206
cdd54d2 
.

Issue #205 removed all tabs from all files.

To retain consistency with our style guide, we should make sure GHC
detects and warns about any tabs introduced.

This commit removes local options in tests that disable GHC warnings due
to tabs being present in files.
ivanperez-keera added a commit that referenced this issue May 14, 2022
@ivanperez-keera
yampa-test: Enable all warnings on regression tests. Refs #206.
d6b3098 
Issue #205 removed all tabs from all files.

To retain consistency with our style guide, we should make sure GHC
detects and warns about any tabs introduced.

This commit enables Wall for regression tests which, among others, warns
about tabs.
@ivanperez-keera ivanperez-keera mentioned this issue Apr 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanperez-keera ivanperez-keera

Labels
maintenance
Projects
None yet
Milestone
Yampa 0.13.5
Development

No branches or pull requests
1 participant
@ivanperez-keera