Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tabs warning detection #206

Closed
ivanperez-keera opened this issue May 14, 2022 · 0 comments
Closed

Enable tabs warning detection #206

ivanperez-keera opened this issue May 14, 2022 · 0 comments
Assignees
@ivanperez-keera
Labels
maintenance
Milestone
Yampa 0.13.5

Comments

@ivanperez-keera
Copy link
Owner

Issue #205 removed all tabs from all files.

To retain consistency with our style guide, we should make sure GHC detects and warns about any tabs introduced.
@ivanperez-keera ivanperez-keera added this to the (+1) milestone May 14, 2022
@ivanperez-keera ivanperez-keera self-assigned this May 14, 2022
ivanperez-keera added a commit that referenced this issue May 14, 2022
@ivanperez-keera
yampa-test: Remove local GHC option disable warnings for tabs. Refs #206
cdd54d2 
.

Issue #205 removed all tabs from all files.

To retain consistency with our style guide, we should make sure GHC
detects and warns about any tabs introduced.

This commit removes local options in tests that disable GHC warnings due
to tabs being present in files.
ivanperez-keera added a commit that referenced this issue May 14, 2022
@ivanperez-keera
yampa-test: Enable all warnings on regression tests. Refs #206.
d6b3098 
Issue #205 removed all tabs from all files.

To retain consistency with our style guide, we should make sure GHC
detects and warns about any tabs introduced.

This commit enables Wall for regression tests which, among others, warns
about tabs.
ivanperez-keera added a commit that referenced this issue May 14, 2022
@ivanperez-keera
Document changes in yampa-test:CHANGELOG. Refs #206.
af2f173
@ivanperez-keera ivanperez-keera mentioned this issue Apr 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanperez-keera ivanperez-keera

Labels
maintenance
Projects
None yet
Milestone
Yampa 0.13.5
Development

No branches or pull requests
1 participant
@ivanperez-keera