Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bearriver: Offer all definitions from FRP.Yampa.Arrow #360

Closed
ivanperez-keera opened this issue Apr 24, 2023 · 0 comments
Closed

bearriver: Offer all definitions from FRP.Yampa.Arrow #360

ivanperez-keera opened this issue Apr 24, 2023 · 0 comments
Assignees
@ivanperez-keera
Labels
enhancement
Milestone
Dunai 0.11.1

Comments

@ivanperez-keera
Copy link
Owner

The module FRP.Yampa.Arrow is being offered by Yampa, but not bearriver.

This makes the interface offered by bearriver not compliant with Yampa, therefore not delivering on the promise of being API-compatible.

This is a subissue of #40. Because #40 is a big issue, it's good to split it in several smaller ones.
@ivanperez-keera ivanperez-keera mentioned this issue Apr 24, 2023
Closed
ivanperez-keera added a commit that referenced this issue Apr 30, 2023
@ivanperez-keera
bearriver: Port module FRP.Yampa.Arrow to bearriver. Refs #360.
6da9cf5 
The module FRP.Yampa.Arrow is being offered by Yampa, but not bearriver.
This makes the interface offered by bearriver not compliant with Yampa,
therefore not delivering on the promise of being API-compatible.

This commit adds the module FRP.Yampa.Arrow into bearriver, as
FRP.BearRiver.Arrow.
ivanperez-keera added a commit that referenced this issue Apr 30, 2023
@ivanperez-keera
bearriver: Re-export all definitions from FRP.BearRiver.Arrow. Refs #360
175d7e2 
.

The module FRP.Yampa.Arrow is being offered by Yampa, but not bearriver.
This makes the interface offered by bearriver not compliant with Yampa,
therefore not delivering on the promise of being API-compatible.
A new module, FRP.BearRiver.Arrow has been added, which is a port of
FRP.Yampa.Arrow.

This commit re-exports all the definitions in FRP.BearRiver.Arrow from
FRP.BearRiver. Because these definitions are also re-exported from
FRP.Yampa, this makes bearriver more API-compatible with Yampa overall.

A function `dup` was being defined directly in FRP.BearRiver, which is
now taken from FRP.BearRiver.Arrow.
ivanperez-keera added a commit that referenced this issue Apr 30, 2023
@ivanperez-keera
bearriver: Document changes in CHANGELOG. Refs #360.
702abb0
@ivanperez-keera ivanperez-keera self-assigned this Apr 30, 2023
@ivanperez-keera ivanperez-keera added this to the Dunai 0.(11+X).(0+Y) milestone Apr 30, 2023
@ivanperez-keera ivanperez-keera mentioned this issue Nov 3, 2024
Closed
solomon-b added a commit to solomon-b/dunai that referenced this issue Nov 3, 2024
@solomon-b
dunai-examples: Remove duplicated function. Refs ivanperez-keera#452.
fc7ea54 
The example bearriver-examples-bouncingball-list defines a function arr2
equivalent to Yampa's original arr2 function. The fix for issue ivanperez-keera#360 defined
all functions offered by the corresponding Yampa module, so that re-definition
as part of the example is no longer necessary. The example no longer compiles
for that reason.

This commit removes arr2, so that the function coming from `FRP.Yampa` is
used instead.
@solomon-b solomon-b mentioned this issue Nov 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanperez-keera ivanperez-keera

Labels
enhancement
Projects
None yet
Milestone
Dunai 0.11.1
Development

No branches or pull requests
1 participant
@ivanperez-keera