dunai-examples: Remove duplicated function. Refs #452. #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example bearriver-examples-bouncingball-list defines a function arr2 equivalent to Yampa's original arr2 function. The fix for issue ivanperez-keera#360 defined all functions offered by the corresponding Yampa module, so that re-definition as part of the example is no longer necessary. The example no longer compiles for that reason. This commit removes arr2, so that the function coming from `FRP.Yampa` is used instead.
|
NOTE: Without fixing |
|
Thanks again, @solomon-b . Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example bearriver-examples-bouncingball-list defines a function arr2 equivalent to Yampa's original arr2 function. The fix for issue #360 defined all functions offered by the corresponding Yampa module, so that re-definition as part of the example is no longer necessary. The example no longer compiles for that reason.
This commit removes arr2, so that the function coming from
FRP.Yampais used instead.