Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acos #10800 #10863

Closed
wants to merge 10,000 commits into from
Closed

acos #10800 #10863

wants to merge 10,000 commits into from

Conversation

SSahas
Copy link
Contributor

@SSahas SSahas commented Feb 23, 2023

close #10800

AnnaTz and others added 30 commits February 13, 2023 10:00
Co-authored by: Dev-Khant <devkhant24@gmail.com>, nassimberrada <Nassim>
Co-authored-by: CatB1t <skytedits@gmail.com>
Co-authored-by: agniiyer <agni.iyer14@alumni.imperial.ac.uk>
Co-authored-by: agniiyer <agni.iyer14@alumni.imperial.ac.uk>
Co-authored-by: sherry30 <sherrytst30@gmail.com>
…end because `jax.image.resize` doesn't support it
* Add divmod method for jax frontend

* use floor_divide instead of divide
* tensorflow.roll implementation

* code formating

* added required changes
xoiga123 and others added 11 commits February 24, 2023 18:02
Co-authored-by: Aditya Hari <adityahari3791@gmail.com>
Co-authored-by: sherry30 <sherrytst30@gmail.com>
* Added cosh instance method to pytorch frontend

Co-authored-by: YushaArif<101613943+YushaArif99@users.noreply.github.com>
Co-authored-by: Felix Hirwa Nshuti <hirwanshutiflx@gmail.com>
Co-authored-by: Felix Hirwa Nshuti <hirwanshutiflx@gmail.com>
@vaatsalya123
Copy link
Contributor

vaatsalya123 commented Feb 25, 2023

Hey @SSahas first of all thanks for contributing to Ivy , I had a look through your PR but it seems a little incomplete and requires a few changes I would say :

1.) Open the issue your addressing and link it in the PR as that helps us track the issues already addressed I would recommend going through the docs to get a better understanding of this.

2.) It's always a good practice to also implement tests for the frontend function you've implemented as that helps us understand if the frontend function is valid.Please refer to the docs for how to do that in more brief detail (:

That's all I would recommend once these issues have been addressed we can get this PR merged thanks!

Plutone11011 and others added 16 commits February 25, 2023 15:14
Co-authored-by: agniiyer <agni.iyer14@alumni.imperial.ac.uk>
* Remove reference to now deleted setting up discussion in setting_up.rst

* Fix typo in Empty Suite error section of setting_up.rst
Co-authored-by: CatB1t <skytedits@gmail.com>
to fix their behavior with multiple axises to reduce
Co-authored-by: nathzi1505 <41519676+nathzi1505@users.noreply.github.com>
Co-authored-by: nathzi1505 <41519676+nathzi1505@users.noreply.github.com>
Co-authored-by: nathzi1505 <41519676+nathzi1505@users.noreply.github.com>
Added tf.asin  to the TF frontend

Co-authored-by: Yusha Arif <101613943+YushaArif99@users.noreply.github.com>
Added poisson_nll_loss to the PyTorch frontend. 

Co-authored-by: Yusha Arif <101613943+YushaArif99@users.noreply.github.com>
Added log instance method to the PyTorch frontend

Co-authored by: Yusha Arif <101613943+YushaArif99@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

acos