Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "meta" task doesn't work #9

Closed
fireboy1919 opened this issue Apr 14, 2015 · 1 comment · Fixed by #11
Closed

The "meta" task doesn't work #9

fireboy1919 opened this issue Apr 14, 2015 · 1 comment · Fixed by #11

Comments

@fireboy1919
Copy link

Assuming you figure out that you need the "through2" plugin, the meta task does not work.

It throws an exception:
TypeError: Cannot read property 'length' of null
fireboy1919 added a commit to fireboy1919/vinyl-s3 that referenced this issue Apr 14, 2015
@fireboy1919
Fixes issue izaakschroeder#9.
7e77d22
izaakschroeder added a commit that referenced this issue Apr 15, 2015
@izaakschroeder
Add missing isNull check for mapping vinyl metadata.
3f0ca27 
When requesting only metadata (i.e. `{ read: false }`) the check for the `.length` property on the file's contents will fail because the file has no contents. A check is added to deal with this case and a corresponding test has been provided.

Additionally the README has been updated to include an otherwise missing module, and the examples folder now includes an example for just retrieving the metadata.

This fixes #9.
@izaakschroeder izaakschroeder mentioned this issue Apr 15, 2015
Merged
@fireboy1919
Copy link
Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing isNull check for mapping vinyl metadata. izaakschroeder/vinyl-s3
1 participant
@fireboy1919