Add missing isNull check for mapping vinyl metadata.
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When requesting only metadata (i.e. `{ read: false }`) the check for the `.length` property on the file's contents will fail because the file has no contents. A check is added to deal with this case and a corresponding test has been provided.
Additionally the README has been updated to include an otherwise missing module, and the examples folder now includes an example for just retrieving the metadata.
This fixes #9.
|
See also: #10 |
Closed
izaakschroeder
added a commit
that referenced
this pull request
Apr 15, 2015
Add missing `isNull` check for mapping vinyl metadata.
jwulf
added a commit
to jwulf/vinyl-s3
that referenced
this pull request
Feb 23, 2017
Incorporate credentials updates from izaakschroeder#11 and izaakschroeder#20.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting only metadata (i.e.
{ read: false }) the check for the.lengthproperty on the file's contents will fail because the file has no contents. A check is added to deal with this case and a corresponding test has been provided.Additionally the README has been updated to include an otherwise missing module, and the examples folder now includes an example for just retrieving the metadata.
This fixes #9.