Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ClipAction.getAnimClip() method and remove ClipAction.reset() method #2194

Closed
capdevon opened this issue Feb 8, 2024 · 1 comment

Comments

@capdevon
Copy link
Contributor

capdevon commented Feb 8, 2024

Although the constructor of the ClipAction class requires an AnimClip, there is no getter method ClipAction.getAnimClip().
Could this be added please?

Here is a use case:

        StringBuilder sb = new StringBuilder();
        Action action = animComposer.getCurrentAction();

        if (action != null) {
            sb.append("ActionType=").append(action.getClass()).append('\n');
            sb.append("Length=").append(timeLength).append('\n');
            sb.append("Speed=").append(action.getSpeed()).append('\n');

            if (action instanceof ClipAction) {
                ClipAction ca = (ClipAction) action;

                try {
                    // Use reflection here because the ClipAction.getAnimClip() method does not exist. Why ???
                    AnimClip clip = (AnimClip) FieldUtils.readField(ca, "clip", true);
                    sb.append("ClipName=").append(clip.getName()).append('\n');
                    sb.append("Duration (sec)=").append(clip.getLength()).append('\n');
                    sb.append("Tracks=").append(clip.getTracks().length).append('\n');

                } catch (ReflectiveOperationException e) {
                    e.printStackTrace();
                }

                sb.append("TransitionLength=").append(ca.getTransitionLength()).append('\n');
                sb.append("MaxTransitionWeight=").append(ca.getMaxTransitionWeight()).append('\n');
                sb.append("Weight=").append(ca.getWeight()).append('\n');
                sb.append("TargetTransforms=").append(ca.getTargets().size()).append('\n');
            }
        }

https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/anim/tween/action/ClipAction.java#L13


Also could you remove the ClipAction.reset() method which does nothing?

https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/anim/tween/action/ClipAction.java#L62

scenemax3d pushed a commit that referenced this issue Feb 27, 2024
…method (#2195)

 Add the ClipAction.getAnimClip() method and remove ClipAction.reset() method
@capdevon
Copy link
Contributor Author

capdevon commented Mar 3, 2024

completed in #2195

@capdevon capdevon closed this as completed Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant