Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2194 add ClipAction.getAnimClip() method, remove ClipAction.reset() method #2195

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

capdevon
Copy link
Contributor

@capdevon capdevon commented Feb 9, 2024

add jMonkeyEngine license

@capdevon capdevon changed the title Add the ClipAction.getAnimClip() method and remove ClipAction.reset() method #2194 add ClipAction.getAnimClip() method, remove ClipAction.reset() method Feb 9, 2024
@scenemax3d
Copy link
Contributor

Hi @capdevon ,
Can you explain why did you remove the reset() method?

Thanks!

@capdevon
Copy link
Contributor Author

capdevon commented Feb 19, 2024

Hi @scenemax3d , the ClipAction.reset() method is empty and does nothing.
It is a method that was left incomplete in the transition to the new animation system.
Removing it does not cause any problem. In my opinion it only creates confusion and lowers the quality of the code.

@pavly-gerges
Copy link
Contributor

Yes, either to implement the method or remove it completely, however implementation will require a discussion on forum and some prerequisites, and thus another completely different PR. @scenemax3d If you want to support resetting ClipActions, then you might consider opening an issue for a later implementation.

@scenemax3d scenemax3d merged commit d3ed914 into jMonkeyEngine:master Feb 27, 2024
14 checks passed
@capdevon capdevon deleted the capdevon-clip-action branch March 1, 2024 08:50
@stephengold stephengold added this to the v3.7.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants