jme-core: IndexBuffer fixes & API improvements #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in: https://hub.jmonkeyengine.org/t/indexbuffer-suggestions-improvements-consistency/42022/4 * [Fix] createIndexBuffer(int, int): return IndexByteBuffer as well for vertexCount < 128 * [Enhancement] Make put(int i, int value) fluid interface * [Enhancement] Add relative put(int i) to allow easier chaining (parity with other buffer implementations) * [Enhancement] Add getFormat() to allow setting an IndexBuffer to a Mesh directly without type inspection. * [Fix] Fix WrappedIndexBuffer API changes make it possible that IndexByteBuffer is now a valid type for outBuf, leverage the new getFormat() method to set the buffer to the mesh regardless of its type.
riccardobl
approved these changes
Jul 4, 2019
Member
riccardobl
left a comment
riccardobl
left a comment
There was a problem hiding this comment.
Looks ok.
Should we also update this code?
Contributor
Author
|
There are likely more places inside JME where IndexBuffer should be used. I remarked the above place in the forum thread, but I didn't want to clutter this PR also with updates of the whole codebase. If wanted I can include that change in this PR. |
Member
|
I think it should be done. Mostly because with the current code, mesh2.extractVertexData(meshWithByteIndex) will make a short index buffer instead of a byte one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in:
https://hub.jmonkeyengine.org/t/indexbuffer-suggestions-improvements-consistency/42022/4
vertexCount < 128
with other buffer implementations)
Mesh directly without type inspection.
API changes make it possible that IndexByteBuffer is now a valid type
for outBuf, leverage the new getFormat() method to set the buffer to the
mesh regardless of its type.