Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Character Issues report to reflect new character information data #1139

Closed
warrensearle opened this issue Jan 12, 2021 · 6 comments
Closed
Assignees
Labels

Comments

@warrensearle
Copy link
Member

warrensearle commented Jan 12, 2021

Now that character information has grown considerably in apply#563 we need to update the Character Issues report.
We will also revisit the data model for how we store character issues on applicationRecord.

@KateMJAC
Copy link

Assigned to Halcyon's March WO.

@KateMJAC
Copy link

Maria is able to provide information in relation to the new character information data.

@KateMJAC KateMJAC assigned JeremykJAC and unassigned warrensearle Feb 26, 2021
@HalcyonJAC HalcyonJAC added the question Further information is requested label Mar 15, 2021
@HalcyonJAC
Copy link
Contributor

HalcyonJAC commented Mar 16, 2021

Hi guys

I have either found a bug or the system just doesn't work how I expect:

I have applied for 2 exercises locally. When I get to the Character Information page the input boxes have the same values in them whatever I do.

For example, I opened an application for exercise 'P4BWVWQBynf72vwboUg6' and filled in the character info section - see below:

image.png

...if I then load my application (which was in progrss) for exercise 'mzdAdY3zBAAQkbHGOJgg' I see the input boxes have the same values in them for some reason:

image.png

Can someone point me in the right direction here please?

Darrel

@HalcyonJAC
Copy link
Contributor

HalcyonJAC commented Mar 18, 2021

Hi

I have updated the flagApplicationIssuesForExercise endpoint to use characterInformationV2 when appropriate and created a seperate issue (#515) on the Digital Platform for this, which populates the character issue info in the applicationRecords collection.

The admin portal now needs updating too though as the Character Issues report currently looks for the character info data in the allocations collection. There may be other changes related to this also, in issue #1071, so (as discussed with Warren) I have blocked this issue (#1139) for now and submitted the Digital Platform changes for code review. The remainder of this piece of development can then ither be picked up as part of issue #1071 or immediately after it.

Darrel

@HalcyonJAC HalcyonJAC removed the question Further information is requested label Apr 19, 2021
@KateMJAC KateMJAC added the 21MAR label Apr 26, 2021
@warrensearle
Copy link
Member Author

Have un-blocked this. The fix in #1071 is to ensure the UI is looking at the applicationRecords collection instead of applications. This has been applied in the following PR #1337

@HalcyonJAC
Copy link
Contributor

HalcyonJAC commented May 20, 2021

  • Digital Platform - exportApplicationCharacterIssues function needs to look at applicationRecords instead of applications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants