#1071 Fix character issues report #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrensearle
requested review from
lloback,
JeremykJAC,
tomlovesgithub and
KateMJAC
warrensearle
requested review from
HalcyonJAC,
mbrookeswebdev and
tomlovesgithub
and removed request for
lloback,
tomlovesgithub and
JeremykJAC
warrensearle
requested review from
HalcyonJAC
and removed request for
KateMJAC,
HalcyonJAC,
mbrookeswebdev and
tomlovesgithub
mbrookeswebdev
approved these changes
May 20, 2021
|
Visit the preview URL for this PR (updated for commit b1f6d95): https://jac-admin-develop--pr1337-feature-1071-charact-kkujbghh.web.app (expires Sat, 19 Jun 2021 13:44:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
The character issues report was either blank or showing the wrong data.
This PR fixes that by ensuring we are looking at the
applicationRecordscollection instead ofapplications.This un-blocks #1139 which will make further changes to this report
Who should test?
✅ Developers
How to test?
View the character issues report and check that it is now displaying.
NOTE: #1139 will make further changes / fixes after which more thorough testing can happen
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING