Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Changes Associated With #1952 Equality And Diversity Changes #2014

Closed
drieJAC opened this issue May 18, 2023 · 1 comment · Fixed by #2015
Closed

Missing Changes Associated With #1952 Equality And Diversity Changes #2014

drieJAC opened this issue May 18, 2023 · 1 comment · Fixed by #2015
Assignees
Labels
Bug Something isn't working

Comments

@drieJAC
Copy link
Contributor

drieJAC commented May 18, 2023

Describe the bug
As part of the work for #1952 the social mobility questions can be either firstGenerationUniversity or parentsAttendedUniversity.
The Diversity view does not account for this change, it only displays firstGenerationUniversity. If this is not present in the data then an error is displayed in the console.

To Reproduce
Steps to reproduce the behavior:

  1. Select an exercise which has a report
  2. Click on the 'Reports' tab
  3. The error will appear in the console

Expected behavior
No error in the console

Screenshots
Equality And Diversity Changes Bug

Desktop (please complete the following information):

  • OS: iOS
  • Browser chrome
  • Version 112.0.5615.137
@andrew-isaac
Copy link

Changes have only been rolled out to admin and not apply - The release for apply is sitting in draft and candidates for 164 saw the old questions on apply but on admin it has the new questions with no answers

image.png

@andrew-isaac andrew-isaac added Bug Something isn't working Needs UT and removed Needs UT labels May 24, 2023
drieJAC added a commit that referenced this issue Jun 2, 2023
* Added check for social mobility university attendance as missing from original ticket.

* Added extra check for post 01/04/23 questions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants