Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2014 Fix Associated With Equality And Diversity Changes #2015

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

drieJAC
Copy link
Contributor

@drieJAC drieJAC commented May 18, 2023

What's included?

As part of the work for #1952 the social mobility questions can be either firstGenerationUniversity or parentsAttendedUniversity.
The Diversity view does not account for this change, it only displays firstGenerationUniversity. If this is not present in the data then an error is displayed in the console.

closes #2014

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Select an exercise which has a report
Click on the 'Reports' tab
The error will appear in the console

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work
🟠 Medium risk - this does change code that is shared with other areas
🔴 High risk - this includes a lot of changes to shared code

Additional context

Equality And Diversity Changes Bug

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@drieJAC drieJAC requested review from a team as code owners May 18, 2023 10:04
@drieJAC drieJAC requested a review from NormaJAC May 18, 2023 10:04
@drieJAC drieJAC temporarily deployed to develop May 18, 2023 10:06 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented May 18, 2023

Visit the preview URL for this PR (updated for commit c36a26c):

https://jac-admin-develop--pr2015-hotfix-2014-fix-for-jkpa2ijm.web.app

(expires Sun, 02 Jul 2023 09:55:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@drieJAC drieJAC temporarily deployed to develop June 2, 2023 09:52 — with GitHub Actions Inactive
@drieJAC drieJAC merged commit f7cc62b into main Jun 2, 2023
@drieJAC drieJAC deleted the hotfix/2014-fix-for-equality-and-diversity branch June 2, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Changes Associated With #1952 Equality And Diversity Changes
4 participants