#945 Improve analysis of qualifying test questions #1317

lloback · 2021-05-06T09:31:22Z

What's included?

Changed the TAB title from "Logs" to "Connection Logs"
Created the "HISTORY" tab
Added Analytics information and the amount of time user spent on the question

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

You need to start or edit a test on the apply

Situational Judgement
Critical Analysis
Scenario

On each of the tests you will be able to see a new TAB called HISTORY

This tan will contain analytics information about the test

Risk - how likely is this to impact other areas?

🟠 Medium risk - this does change code that is shared with other areas

Additional context

This task should be performed in conjunction with the apply#517

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

github-actions · 2021-05-06T09:34:54Z

Visit the preview URL for this PR (updated for commit f13d41e):

https://jac-admin-develop--pr1317-feature-945-qt-analy-uu99mxb6.web.app

_{(expires Fri, 03 Sep 2021 15:21:21 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

mbrookeswebdev

Perhaps numbers of questions in History tab should start from 1, rather than 0.

And 23:59:40 start line in this case is a little confusing. Maybe it's worth to remove it or set to 00:00:00 if the intention is to show how long it took the candidate to look at the question.

lloback · 2021-05-10T10:16:51Z

@mbrookeswebdev I've did the changes that you asked on the PR:

Changed the indexed question number, to be "Question 1" instead of "Question 0"
Removed the "23:59:40" meaning that the first item is always "00:00:00"

warrensearle

Looks good to me 👍

HalcyonJAC

This looks fine, but I would make it more legible by making the Question marker bold or something - as its a lot of text in the same style which can make it difficult as so:

lloback · 2021-05-10T14:45:35Z

@HalcyonJAC this is done. Thank you for your feedback.

HalcyonJAC

👍

KateMJAC

This has been sent to UTG. An update will follow.

It looks really exciting!!!!

KateMJAC

Hello @lloback, I just tested this and the history logs didn't populate. I checked during the QT before I submitted the application and after I submitted and the QT was closed and scored, but I was unable to see any logged behaviour in the history tab.

lloback · 2021-05-18T14:48:20Z

Hello @lloback, I just tested this and the history logs didn't populate. I checked during the QT before I submitted the application and after I submitted and the QT was closed and scored, but I was unable to see any logged behaviour in the history tab.

Did you use the link? https://jac-admin-develop--pr1317-feature-945-qt-analy-0sef2z9x.web.app/

lloback · 2021-05-18T14:49:03Z

TO test this you need to use the link from the other PR on apply: https://jac-apply-develop--pr774-feature-517-qt-analy-9pq48dii.web.app/
because this code is not on the normal apply yet @KateMJAC

KateMJAC · 2021-05-19T13:47:53Z

Hello @lloback yes, i'm sure I used the link on #774 PR. I can try it again, as it's possible I mixed the two up.

This is out with the UTG so we'll see how they go. They have been provided the two different URLs.

KateMJAC · 2021-05-19T15:03:38Z

@lloback I just went back to test it and it worked as it should. So I must have used the wrong link or something. So ignore me.

Still waiting on UTG feedback though.

KateMJAC

We are still getting a mixed back on testing via the UTG on this, comments below:

I have just tested this and it appears that the connection log is working fine, but the history log is not recording accurately, as we skipped questions and returned to questions but it is showing as 0.

2)Ticket 1317 - connection log worked fine and history log showed stats for all areas including times visited, saved, skipped and changed, although I don't think accurate as I didn't skip any questions and shows 1 skipped.

joy-ade · 2021-05-24T09:21:28Z

@lloback
This is a comment from Kate can you look into this pls.
We are still getting a mixed back on testing via the UTG on this, comments below:

I have just tested this and it appears that the connection log is working fine, but the history log is not recording accurately, as we skipped questions and returned to questions but it is showing as 0.
2)Ticket 1317 - connection log worked fine and history log showed stats for all areas including times visited, saved, skipped and changed, although I don't think accurate as I didn't skip any questions and shows 1 skipped.

- Created the "HISTORY" tab - Added Analytics information and the amount of time user spent on the question

lloback · 2021-05-25T22:05:54Z

Hi @KateMJAC and @joy-ade I've reviewed the code and addressed all the issues that were pending.
Please review again.

joy-ade · 2021-05-27T14:36:55Z

@lloback We are still getting mix feedback from UTG see comment and screen shoot below.
I have created and completed a scenario QT the connection logs tab correctly shows the time logged in and out. The history log is incorrect for 'amount of time on question' however the more detailed log below this does seem to be accurate.

KateMJAC · 2021-06-02T15:35:46Z

@lloback following Joy's last message please find a screenshot that details specifically what went wrong here: https://app.zenhub.com/files/201485031/55a3495d-b99b-4668-bdc5-f00169f346ee/download

I believe this was tested after your last post, but I will send it out again to this week's testers.

lloback · 2021-06-16T18:29:09Z

@lloback following Joy's last message please find a screenshot that details specifically what went wrong here: https://app.zenhub.com/files/201485031/55a3495d-b99b-4668-bdc5-f00169f346ee/download

I believe this was tested after your last post, but I will send it out again to this week's testers.

This image has nothing to do with this task. If you want something changed on this page we need to create a ticket for it. The image you attached was an old attempt of calculating the time that people stay on each question. It takes the timestamp when you enter and then the timestamp where you leave. It is prone for errors because you may come back and the time will increase exponentially. I actually think that we should remove it from this page (I can create a task for that if you want)

If no further feedback was added to this new statistic page that we created, I would like this PR to be reviewed and approved.

@joy-ade @KateMJAC @warrensearle

KateMJAC · 2021-06-30T10:50:50Z

@lloback Warren dropped me a line on this ticket and I provided him with additional feedback provided by the UTG.

He has advised that the PR can be left open for now.

@joy-ade

joy-ade · 2021-06-30T10:54:56Z

@KateMJAC thank you for the update

londonprojects · 2021-07-18T15:16:10Z

Hello @warrensearle @lloback What is the issue here?

warrensearle · 2021-07-20T08:28:27Z

@lloback there is a discrepancy around what the 'changes' statistic means. It looks like we are counting every time the answer is saved however the UTG are expecting the count to be only those times the answer is changed from one value to another - i.e. excluding the first save and any skips.
We should aim to meet UTG expectations but if not possible we should update the wording so it is clear what the count represents.

See related Apply ticket - jac-uk/apply#774

lloback · 2021-07-30T13:21:27Z

The issues were changed on the apply banch.
All merge conflicts gone.

warrensearle · 2021-08-04T15:26:00Z

Hey @KateMJAC @joy-ade please can you test this again in combination with jac-uk/apply#774

joy-ade · 2021-08-10T11:20:27Z

out to UTG 9/08/2021 awaiting feedbacks

joy-ade

Approved by product team and UTG

* #945 Improve analysis of qualifying test questions (#1317) * - Changed the TAB title from "Logs" to "Connection Logs" - Created the "HISTORY" tab - Added Analytics information and the amount of time user spent on the question * [945] resolve conflict * [945] fix build * Revert changes to package-lock * Revert changes to package.json Co-authored-by: Warren Searle <warren@precise-minds.co.uk> * #1440 QT fixes (#1468) * Reports. Handle report not having data / existing * Tidy sass imports to speed up build * Fix console error when logged out and ensure menu only shows when logged in * Fix paging list of dry run responses * Remove duration estimate now we have history log * #1274 Fix: QT Connection logs not showing * Show when question was last updated * Fix sorting list of responses for dry run * Bump version number to 0.73.0 * Update readme * Bump version number to 0.74.0 * #1472 Fix: name blind sift link not showing up (#1473) * #1472 Fix: name blind sift link not showing up * Look at shortlisting methods as well as dates * Tidy * Tidy * #1356 Display client details of QT participant (#1479) * Bump version number to 0.75.0 * Input custom ASC word limits (#1478) * input custom ASC word limits * fix * Feature/1327 enable request of character check form completion (#1357) * WIP * WIP * WIP * WIP * WIP * Revert wrong commit * Removing wrong changes * WIP * WIP * #1327 WIP * #1327 A change to store file to show consent form completed app records in a tab * #1327 Remove redundant code * #1327 Changes to update appRecord * #1327 Added a button to enable character checks * #1327 Added characterChecksEnabled flag to exercise * #1327 Changed button type * #1327 Added Other Professional Bodies section * #1327 Changed Consent checks tab to reflect consent form changes * #1327 Display professional details date correctly * Bump version number to 0.76.0 * #639 Added the approved email, removed a no-longer-in-use email (#1483) * #589 Implement firebase app check (#1453) * Upgrade firebase to V8 & add App Check * Env / workflow changes to include recaptcha token * Update on-release.yml * #1314/additonal legal experience (#1331) * admin ui * connect to variables * allow for applications without judicialFunctions object * handle no answer provided * handle no answer provided * handle no answer provided * handle no answer provided * handle no answer provided * admin ui * connect to variables * allow for applications without judicialFunctions object * handle no answer provided * handle no answer provided * handle no answer provided * handle no answer provided * handle no answer provided * working again added, workign basis inc * UI sorted * add judicial functions to review * conditionally show total days engaged * #1484 Placed data into correct columns (#1487) * Revert "#589 Implement firebase app check (#1453)" (#1490) This reverts commit b6cdd3b. Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Warren Searle <warren@precise-minds.co.uk> Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> Co-authored-by: Maria Brookes <40855898+mbrookeswebdev@users.noreply.github.com> Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com>

* use new editablefield component * wip * stillwip * wip * wip * wip * add/remove info sections * editable character information section * wip * merge sorted (?) * broken * fix? * fixing tests wip * tests working * ready for reveiw * remove unneeded imports * remove unneeded imports * wip * eq-div-survey page done * wip * wip * wip * wip * tidy * wip * wip * wip * wip * wip * wip * wip * wip * fully functional * Test merge (#1493) * #945 Improve analysis of qualifying test questions (#1317) * - Changed the TAB title from "Logs" to "Connection Logs" - Created the "HISTORY" tab - Added Analytics information and the amount of time user spent on the question * [945] resolve conflict * [945] fix build * Revert changes to package-lock * Revert changes to package.json Co-authored-by: Warren Searle <warren@precise-minds.co.uk> * #1440 QT fixes (#1468) * Reports. Handle report not having data / existing * Tidy sass imports to speed up build * Fix console error when logged out and ensure menu only shows when logged in * Fix paging list of dry run responses * Remove duration estimate now we have history log * #1274 Fix: QT Connection logs not showing * Show when question was last updated * Fix sorting list of responses for dry run * Bump version number to 0.73.0 * Update readme * Bump version number to 0.74.0 * #1472 Fix: name blind sift link not showing up (#1473) * #1472 Fix: name blind sift link not showing up * Look at shortlisting methods as well as dates * Tidy * Tidy * #1356 Display client details of QT participant (#1479) * Bump version number to 0.75.0 * Input custom ASC word limits (#1478) * input custom ASC word limits * fix * Feature/1327 enable request of character check form completion (#1357) * WIP * WIP * WIP * WIP * WIP * Revert wrong commit * Removing wrong changes * WIP * WIP * #1327 WIP * #1327 A change to store file to show consent form completed app records in a tab * #1327 Remove redundant code * #1327 Changes to update appRecord * #1327 Added a button to enable character checks * #1327 Added characterChecksEnabled flag to exercise * #1327 Changed button type * #1327 Added Other Professional Bodies section * #1327 Changed Consent checks tab to reflect consent form changes * #1327 Display professional details date correctly * Bump version number to 0.76.0 * #639 Added the approved email, removed a no-longer-in-use email (#1483) * #589 Implement firebase app check (#1453) * Upgrade firebase to V8 & add App Check * Env / workflow changes to include recaptcha token * Update on-release.yml * #1314/additonal legal experience (#1331) * admin ui * connect to variables * allow for applications without judicialFunctions object * handle no answer provided * handle no answer provided * handle no answer provided * handle no answer provided * handle no answer provided * admin ui * connect to variables * allow for applications without judicialFunctions object * handle no answer provided * handle no answer provided * handle no answer provided * handle no answer provided * handle no answer provided * working again added, workign basis inc * UI sorted * add judicial functions to review * conditionally show total days engaged * #1484 Placed data into correct columns (#1487) * Revert "#589 Implement firebase app check (#1453)" (#1490) This reverts commit b6cdd3b. Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Warren Searle <warren@precise-minds.co.uk> Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> Co-authored-by: Maria Brookes <40855898+mbrookeswebdev@users.noreply.github.com> Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> * character information section corrected * address PR issues * address PR issues * taskdetails * wip * add task details * fixes * wip * done * styling fixes * done * tidy * tests * tests * * * * * improved - tests failing * tests pass * show 2d questions and answers * show welsh answers according to exercise * address pr comments * use next jac-kit verison * jac-kit version * fix characterv1 edit * fix characterv1 edit * fix characterv1 edit * update jac-kit version to new beta * update jac-kit version to new beta * update ranked selection * share logic for character summaries * character summary shared logic * hide edit button for nonauth * merge and fix * allow personal detailsa character sections to be editable by all * rollback to remove code spill * wip Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Warren Searle <warren@precise-minds.co.uk> Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> Co-authored-by: Maria Brookes <40855898+mbrookeswebdev@users.noreply.github.com> Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com>

* use new editablefield component * wip * stillwip * wip * wip * wip * add/remove info sections * editable character information section * wip * merge sorted (?) * broken * fix? * fixing tests wip * tests working * ready for reveiw * remove unneeded imports * remove unneeded imports * wip * eq-div-survey page done * wip * wip * wip * wip * tidy * wip * wip * wip * wip * wip * wip * wip * wip * fully functional * Test merge (#1493) * #945 Improve analysis of qualifying test questions (#1317) * - Changed the TAB title from "Logs" to "Connection Logs" - Created the "HISTORY" tab - Added Analytics information and the amount of time user spent on the question * [945] resolve conflict * [945] fix build * Revert changes to package-lock * Revert changes to package.json Co-authored-by: Warren Searle <warren@precise-minds.co.uk> * #1440 QT fixes (#1468) * Reports. Handle report not having data / existing * Tidy sass imports to speed up build * Fix console error when logged out and ensure menu only shows when logged in * Fix paging list of dry run responses * Remove duration estimate now we have history log * #1274 Fix: QT Connection logs not showing * Show when question was last updated * Fix sorting list of responses for dry run * Bump version number to 0.73.0 * Update readme * Bump version number to 0.74.0 * #1472 Fix: name blind sift link not showing up (#1473) * #1472 Fix: name blind sift link not showing up * Look at shortlisting methods as well as dates * Tidy * Tidy * #1356 Display client details of QT participant (#1479) * Bump version number to 0.75.0 * Input custom ASC word limits (#1478) * input custom ASC word limits * fix * Feature/1327 enable request of character check form completion (#1357) * WIP * WIP * WIP * WIP * WIP * Revert wrong commit * Removing wrong changes * WIP * WIP * #1327 WIP * #1327 A change to store file to show consent form completed app records in a tab * #1327 Remove redundant code * #1327 Changes to update appRecord * #1327 Added a button to enable character checks * #1327 Added characterChecksEnabled flag to exercise * #1327 Changed button type * #1327 Added Other Professional Bodies section * #1327 Changed Consent checks tab to reflect consent form changes * #1327 Display professional details date correctly * Bump version number to 0.76.0 * #639 Added the approved email, removed a no-longer-in-use email (#1483) * #589 Implement firebase app check (#1453) * Upgrade firebase to V8 & add App Check * Env / workflow changes to include recaptcha token * Update on-release.yml * #1314/additonal legal experience (#1331) * admin ui * connect to variables * allow for applications without judicialFunctions object * handle no answer provided * handle no answer provided * handle no answer provided * handle no answer provided * handle no answer provided * admin ui * connect to variables * allow for applications without judicialFunctions object * handle no answer provided * handle no answer provided * handle no answer provided * handle no answer provided * handle no answer provided * working again added, workign basis inc * UI sorted * add judicial functions to review * conditionally show total days engaged * #1484 Placed data into correct columns (#1487) * Revert "#589 Implement firebase app check (#1453)" (#1490) This reverts commit b6cdd3b. Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Warren Searle <warren@precise-minds.co.uk> Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> Co-authored-by: Maria Brookes <40855898+mbrookeswebdev@users.noreply.github.com> Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> * character information section corrected * address PR issues * address PR issues * taskdetails * wip * add task details * fixes * wip * done * styling fixes * done * tidy * tests * tests * * * * * improved - tests failing * tests pass * show 2d questions and answers * show welsh answers according to exercise * address pr comments * use next jac-kit verison * jac-kit version * fix characterv1 edit * fix characterv1 edit * fix characterv1 edit * update jac-kit version to new beta * update jac-kit version to new beta * update ranked selection * share logic for character summaries * character summary shared logic * hide edit button for nonauth * merge and fix * allow personal detailsa character sections to be editable by all * rollback to remove code spill * wip * wip * wip * wip * wip * use new editablefield component * tests working * show 2d questions and answers * hide edit button for nonauth * allow personal detailsa character sections to be editable by all * wip * wip * wip * fix tests * fix tests * wip * wip * Add version prop * fix tests, additional check for tasks Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Warren Searle <warren@precise-minds.co.uk> Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> Co-authored-by: Maria Brookes <40855898+mbrookeswebdev@users.noreply.github.com> Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com>

lloback requested review from a team as code owners May 6, 2021 09:31

lloback requested review from warrensearle, HalcyonJAC, tomlovesgithub and joy-ade May 6, 2021 09:31

lloback mentioned this pull request May 9, 2021

QT user details: Change "Logs" to "Connection Logs" #1289

Closed

mbrookeswebdev suggested changes May 10, 2021

View reviewed changes

lloback requested a review from mbrookeswebdev May 10, 2021 10:15

mbrookeswebdev approved these changes May 10, 2021

View reviewed changes

warrensearle approved these changes May 10, 2021

View reviewed changes

HalcyonJAC approved these changes May 10, 2021

View reviewed changes

KateMJAC reviewed May 10, 2021

View reviewed changes

KateMJAC reviewed May 18, 2021

View reviewed changes

warrensearle temporarily deployed to develop May 19, 2021 15:22 Inactive

KateMJAC reviewed May 20, 2021

View reviewed changes

- Changed the TAB title from "Logs" to "Connection Logs"

45103c8

- Created the "HISTORY" tab - Added Analytics information and the amount of time user spent on the question

lloback temporarily deployed to develop May 25, 2021 22:00 Inactive

lloback force-pushed the feature/945-qt-analysis branch from e98da40 to 45103c8 Compare May 25, 2021 22:01

lloback temporarily deployed to develop May 25, 2021 22:02 Inactive

warrensearle mentioned this pull request Jul 20, 2021

Apply/517 qt analytics - save History and session time jac-uk/apply#774

Merged

tomlovesgithub approved these changes Jul 21, 2021

View reviewed changes

lloback added 2 commits July 30, 2021 13:13

[945] resolve conflict

8c18836

[945] conflict on package.lock

4abdf75

lloback and others added 3 commits July 31, 2021 09:40

[945] fix build

69a3f04

Revert changes to package-lock

a15ef94

Revert changes to package.json

f13d41e

warrensearle temporarily deployed to develop August 4, 2021 15:16 Inactive

joy-ade approved these changes Aug 10, 2021

View reviewed changes

joy-ade merged commit 1a37970 into main Aug 10, 2021

joy-ade deleted the feature/945-qt-analysis branch August 10, 2021 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#945 Improve analysis of qualifying test questions #1317

#945 Improve analysis of qualifying test questions #1317

lloback commented May 6, 2021 •

edited by warrensearle

Loading

github-actions bot commented May 6, 2021 •

edited

Loading

mbrookeswebdev left a comment

lloback commented May 10, 2021

warrensearle left a comment

HalcyonJAC left a comment

lloback commented May 10, 2021

HalcyonJAC left a comment

KateMJAC left a comment

KateMJAC left a comment

lloback commented May 18, 2021

lloback commented May 18, 2021 •

edited

Loading

KateMJAC commented May 19, 2021

KateMJAC commented May 19, 2021

KateMJAC left a comment

joy-ade commented May 24, 2021

lloback commented May 25, 2021

joy-ade commented May 27, 2021 •

edited

Loading

KateMJAC commented Jun 2, 2021

lloback commented Jun 16, 2021

KateMJAC commented Jun 30, 2021

joy-ade commented Jun 30, 2021

londonprojects commented Jul 18, 2021

warrensearle commented Jul 20, 2021 •

edited

Loading

lloback commented Jul 30, 2021

warrensearle commented Aug 4, 2021 •

edited

Loading

joy-ade commented Aug 10, 2021

joy-ade left a comment

#945 Improve analysis of qualifying test questions #1317

#945 Improve analysis of qualifying test questions #1317

Conversation

lloback commented May 6, 2021 • edited by warrensearle Loading

What's included?

Who should test?

How to test?

Risk - how likely is this to impact other areas?

Additional context

github-actions bot commented May 6, 2021 • edited Loading

mbrookeswebdev left a comment

Choose a reason for hiding this comment

lloback commented May 10, 2021

warrensearle left a comment

Choose a reason for hiding this comment

HalcyonJAC left a comment

Choose a reason for hiding this comment

lloback commented May 10, 2021

HalcyonJAC left a comment

Choose a reason for hiding this comment

KateMJAC left a comment

Choose a reason for hiding this comment

KateMJAC left a comment

Choose a reason for hiding this comment

lloback commented May 18, 2021

lloback commented May 18, 2021 • edited Loading

KateMJAC commented May 19, 2021

KateMJAC commented May 19, 2021

KateMJAC left a comment

Choose a reason for hiding this comment

joy-ade commented May 24, 2021

lloback commented May 25, 2021

joy-ade commented May 27, 2021 • edited Loading

KateMJAC commented Jun 2, 2021

lloback commented Jun 16, 2021

KateMJAC commented Jun 30, 2021

joy-ade commented Jun 30, 2021

londonprojects commented Jul 18, 2021

warrensearle commented Jul 20, 2021 • edited Loading

lloback commented Jul 30, 2021

warrensearle commented Aug 4, 2021 • edited Loading

joy-ade commented Aug 10, 2021

joy-ade left a comment

Choose a reason for hiding this comment

lloback commented May 6, 2021 •

edited by warrensearle

Loading

github-actions bot commented May 6, 2021 •

edited

Loading

lloback commented May 18, 2021 •

edited

Loading

joy-ade commented May 27, 2021 •

edited

Loading

warrensearle commented Jul 20, 2021 •

edited

Loading

warrensearle commented Aug 4, 2021 •

edited

Loading