Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply/517 qt analytics - save History and session time #774

Merged
merged 28 commits into from
Aug 10, 2021

Conversation

lloback
Copy link
Contributor

@lloback lloback commented May 6, 2021

What's included?

On this ticket we are adding History and Session time to the database. This will be stored and showed on the admin side.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

There are no changes to test on the apply as this is a backend ticket - we are just storgin information from the user, without any visual interface or interaction.
This needs to be tested in conjunction with the #945 ticket (admin).

Risk - how likely is this to impact other areas?

🟠 Medium risk - this does change code that is shared with other areas


PREVIEW:DEVELOP

@github-actions
Copy link

github-actions bot commented May 6, 2021

Visit the preview URL for this PR (updated for commit 8286a13):

https://jac-apply-develop--pr774-feature-517-qt-analy-yjoal3l5.web.app

(expires Fri, 03 Sep 2021 15:30:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link

@KateMJAC KateMJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been sent to UTG. An update will follow.

It looks really exciting!!!!

@warrensearle warrensearle temporarily deployed to develop May 19, 2021 15:25 Inactive
- Save history
	- on Exit Modal
	- on information page
	- on review
	- on Situational Judgement
- Save session
	- on skip
	- on SAve
@lloback lloback force-pushed the feature/517-qt-analytics branch from 98fc977 to bd50ca9 Compare May 25, 2021 22:02
@lloback lloback temporarily deployed to develop May 25, 2021 22:04 Inactive
@lloback
Copy link
Contributor Author

lloback commented May 25, 2021

This is ready for re-review.

@warrensearle warrensearle temporarily deployed to develop June 30, 2021 09:30 Inactive
@KateMJAC
Copy link

Please refer to #1317. Some final tweaks required to the tickets which run together.

@londonprojects
Copy link
Contributor

@warrensearle @londonprojects Can someone take a look at this?

@warrensearle
Copy link
Member

@lloback see jac-uk/admin#1317 for changes to make

warrensearle and others added 15 commits July 20, 2021 18:22
* remove name-blind sift and phone assessment from timeline

* fix timeline tests

* delete commented code

Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com>
* Reset PW component with proper validation

* check for valid action code
* Display a generic erorr for wrong password or user not found

* Update SignIn.vue

replicating changes from local copy due to a 403 error

* adding lodash as explicit dependency

Co-authored-by: warrensearle <warren.searle@judicialappointments.digital>
* inital changes

* Update readme

* remove commented code

Co-authored-by: Warren Searle <warren@precise-minds.co.uk>
* wip

* wip

* ranked choice changes

* remove unrelated changes

* remove padding

* remove phantom checkbox

* add to review page

* remove from review page [wrong branch]

Co-authored-by: warrensearle <warren.searle@judicialappointments.digital>
- Save history
	- on Exit Modal
	- on information page
	- on review
	- on Situational Judgement
- Save session
	- on skip
	- on SAve
@lloback lloback temporarily deployed to develop July 20, 2021 17:39 Inactive
@lloback lloback temporarily deployed to develop July 30, 2021 12:00 Inactive
@lloback
Copy link
Contributor Author

lloback commented Jul 30, 2021

Fix the "Saved"

"How many times changed answer:"
The action: 'changed' only works for Situational Judgement and Critical Analysis. Whenever the user clicks on an answer that is different from the previous selection, this count gets updated.

@warrensearle warrensearle temporarily deployed to develop August 4, 2021 15:25 Inactive
@warrensearle
Copy link
Member

Hey @KateMJAC @joy-ade please can you test this again in combination with jac-uk/admin#1317

@joy-ade joy-ade requested a review from KateMJAC August 10, 2021 14:40
@joy-ade joy-ade merged commit d206768 into main Aug 10, 2021
@joy-ade joy-ade deleted the feature/517-qt-analytics branch August 10, 2021 14:40
@joy-ade joy-ade self-assigned this Aug 10, 2021
@joy-ade
Copy link

joy-ade commented Aug 10, 2021

Approved by UTG

@joy-ade joy-ade removed their assignment Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants