#1313 Location preferences #777

tomlovesgithub · 2021-05-10T17:09:52Z

What's included?

There were a few issues with the way that location preferences were being collected, to resolve this i've changed the interface for 'ranked-choice' type questions to be perceptive of one choice per rank.
This streamlines the way things work and negates the issues.
I've also added numbers to review page to show the rank given to each choice

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Apply to an exercise and fill in your location preferences.
Observe new interface
find any bugs?
Check numbers display next to correct location preference on review page

Risk - how likely is this to impact other areas?

🟠 Medium risk - I've done a sweep and tried to ensure the changes to ranked-choice will remain compatible with other places its used, from what i found there was only one other item using the ranked choice component. The issues with location preferences would have been present here too so i believe it should be okay.

Additional context

Include screen grabs, notes etc.

PREVIEW:DEVELOP

github-actions · 2021-05-10T17:14:14Z

Visit the preview URL for this PR (updated for commit 0c123ab):

https://jac-apply-develop--pr777-1313-location-prefs-q6d921qe.web.app

_{(expires Fri, 18 Jun 2021 14:50:05 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

warrensearle

The submit button moves down the page when the check boxes are selected.
See difference between left/right in screen grab below

mbrookeswebdev

Ignore my earlier comment re: can't see the numbers, I've selected multiple choice on Admin (sorry!).

tomlovesgithub · 2021-05-12T15:38:16Z

Just done some work with the padding to stop stuff jumping around.
Numbers should be appearing next to selections too!

mbrookeswebdev

Looks good and I can see numbers, but I can also see something else:

joy-ade · 2021-05-13T14:50:14Z

@kate this looks perfect it can be sent out to UTG.

lloback

This is good to go:

sorted

mbrookeswebdev

👍 Fab, well done!

* wip * wip * ranked choice changes * remove unrelated changes * remove padding * remove phantom checkbox * add to review page * remove from review page [wrong branch] Co-authored-by: warrensearle <warren.searle@judicialappointments.digital>

* 517 Collect more detailed history of qualifying test responses - Save history - on Exit Modal - on information page - on review - on Situational Judgement - Save session - on skip - on SAve * Disable circleci config * Include CODEOWNERS * digital-platform#305 Include pull request template * Include lint and test in PR workflow * Fix the broken preview URLs and workflow (#752) * Small change to test broken * Preview workflow should use node 10, for now * Update package-lock * Small change to test fixed * test to fix Co-authored-by: Tom Russell <TR115251@hotmail.co.uk> * #729 Fixed errors on Qualifications page (#734) * #729 Fixed errors on Qualifications page * #729 Changes as per PR comments Co-authored-by: Maria Brookes <maria_brookes@yahoo.co.uk> Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> * #708 account creation issues (#751) * Add await into account creation - improve password validation * sort sign-in chronology * add and fix password tests * Add await into account creation - improve password validation * sort sign-in chronology * add and fix password tests * fix signUp test Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> * #720 Added a message if vacancy was unpublished (#732) * #720 Added a message if vacancy was unpublished * #720 Display message if vacancy unpublished * Made changes to make applications appear * Made changes to make applications appear * Made changes to make applications appear * WIP * #720 Made changes to accommodate unpublished vacancy Co-authored-by: Maria Brookes <maria_brookes@yahoo.co.uk> Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> * Update github workflow files * Bump version number to 1.39.0 * Remove circleCI config * Update README.md * Bump version number to 1.40.0 * Update workflows to target staging and production * Bump version number to 1.39.0 * Remove name-blind sift and phone assessment from timeline (#753) * remove name-blind sift and phone assessment from timeline * fix timeline tests * delete commented code Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> * Security/769 weak passwords allowed in reset form (#778) * Reset PW component with proper validation * check for valid action code * #771 Authentication Generic Errors (#775) * Display a generic erorr for wrong password or user not found * Update SignIn.vue replicating changes from local copy due to a 403 error * adding lodash as explicit dependency Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> * #1289 Remove gaps in employment from non-legal exercises (#761) * inital changes * Update readme * remove commented code Co-authored-by: Warren Searle <warren@precise-minds.co.uk> * #1313 Location preferences (#777) * wip * wip * ranked choice changes * remove unrelated changes * remove padding * remove phantom checkbox * add to review page * remove from review page [wrong branch] Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> * Workflow: on merge. Change develop to main branch * Bump version number to 1.40.0 * 517 Collect more detailed history of qualifying test responses - Save history - on Exit Modal - on information page - on review - on Situational Judgement - Save session - on skip - on SAve * [517] fix anlytics * [517] resolve conflict package-lock Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: Warren Searle <warren@precise-minds.co.uk> Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> Co-authored-by: Tom Russell <TR115251@hotmail.co.uk> Co-authored-by: Maria Brookes <40855898+mbrookeswebdev@users.noreply.github.com> Co-authored-by: Maria Brookes <maria_brookes@yahoo.co.uk> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com>

tomlovesgithub added 3 commits May 5, 2021 15:35

wip

19aa67d

wip

57fc698

ranked choice changes

8fc1ceb

tomlovesgithub marked this pull request as ready for review May 11, 2021 10:01

tomlovesgithub requested review from a team as code owners May 11, 2021 10:01

tomlovesgithub requested review from lloback, JeremykJAC, mbrookeswebdev and joy-ade May 11, 2021 10:01

remove unrelated changes

f1306db

tomlovesgithub force-pushed the 1313/location-prefs branch from b25012d to f1306db Compare May 11, 2021 10:16

Merge branch 'develop' into 1313/location-prefs

c59a7ef

warrensearle requested changes May 11, 2021

View reviewed changes

mbrookeswebdev suggested changes May 12, 2021

View reviewed changes

tomlovesgithub requested review from warrensearle and mbrookeswebdev May 12, 2021 15:37

remove padding

03eae9e

mbrookeswebdev previously requested changes May 12, 2021

View reviewed changes

remove phantom checkbox

41703d8

tomlovesgithub requested a review from mbrookeswebdev May 13, 2021 13:27

lloback approved these changes May 17, 2021

View reviewed changes

Merge branch 'develop' into 1313/location-prefs

83486db

warrensearle removed their request for review May 18, 2021 12:17

warrensearle approved these changes May 18, 2021

View reviewed changes

warrensearle temporarily deployed to develop May 18, 2021 12:21 Inactive

add to review page

c5eee57

tomlovesgithub temporarily deployed to develop May 19, 2021 14:24 Inactive

remove from review page [wrong branch]

0c123ab

tomlovesgithub temporarily deployed to develop May 19, 2021 14:47 Inactive

HalcyonJAC approved these changes May 20, 2021

View reviewed changes

mbrookeswebdev approved these changes May 20, 2021

View reviewed changes

tomlovesgithub merged commit b2a8055 into develop May 20, 2021

tomlovesgithub deleted the 1313/location-prefs branch May 20, 2021 16:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1313 Location preferences #777

#1313 Location preferences #777

tomlovesgithub commented May 10, 2021 •

edited by warrensearle

Loading

github-actions bot commented May 10, 2021 •

edited

Loading

warrensearle left a comment

mbrookeswebdev left a comment •

edited

Loading

tomlovesgithub commented May 12, 2021 •

edited

Loading

mbrookeswebdev left a comment •

edited

Loading

joy-ade commented May 13, 2021

lloback left a comment

mbrookeswebdev left a comment

#1313 Location preferences #777

#1313 Location preferences #777

Conversation

tomlovesgithub commented May 10, 2021 • edited by warrensearle Loading

What's included?

Who should test?

How to test?

Risk - how likely is this to impact other areas?

Additional context

github-actions bot commented May 10, 2021 • edited Loading

warrensearle left a comment

Choose a reason for hiding this comment

mbrookeswebdev left a comment • edited Loading

Choose a reason for hiding this comment

tomlovesgithub commented May 12, 2021 • edited Loading

mbrookeswebdev left a comment • edited Loading

Choose a reason for hiding this comment

joy-ade commented May 13, 2021

lloback left a comment

Choose a reason for hiding this comment

mbrookeswebdev left a comment

Choose a reason for hiding this comment

tomlovesgithub commented May 10, 2021 •

edited by warrensearle

Loading

github-actions bot commented May 10, 2021 •

edited

Loading

mbrookeswebdev left a comment •

edited

Loading

tomlovesgithub commented May 12, 2021 •

edited

Loading

mbrookeswebdev left a comment •

edited

Loading