#720 Added a message if vacancy was unpublished #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 5bcc90b): https://jac-apply-develop--pr732-feature-720-show-mes-onm2r5al.web.app (expires Tue, 11 May 2021 08:15:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
To test - apply for an exercise, unpublish this exercise on Admin, log into Apply and check Applications tab for a message displaying under the unpublished exercise heading.
|
mbrookeswebdev
requested review from
tomlovesgithub,
warrensearle and
HalcyonJAC
and removed request for
tomlovesgithub and
warrensearle
warrensearle
requested changes
Apr 7, 2021
There was a problem hiding this comment.
Hey @mbrookeswebdev when I look at my list of previous applications most of them now have the 'Data is temporarily unavailable' message. See below:
Looking at the data for exercise 225 it appears to be approved & published just has now closed:
I would expect to still be able to view my previous application
|
@warrensearle The 'vacancies/bind' call made in App.vue on line 115 over-writes the value of records in the vacancies store. I've made some changes to the store, do you have any other ideas how to make this work without spending a lot of time on it? |
|
I tested it locally and it seems to work for me, so if @warrensearle is getting different results it must be data-related
|
tomlovesgithub
approved these changes
Apr 13, 2021
warrensearle
approved these changes
Apr 26, 2021
tomlovesgithub
approved these changes
Apr 26, 2021
KateMJAC
approved these changes
May 4, 2021
mbrookeswebdev
deleted the
feature/720-show-message-if-exercise-unpublished
branch
lloback
pushed a commit
that referenced
this pull request
Jul 20, 2021
* #720 Added a message if vacancy was unpublished * #720 Display message if vacancy unpublished * Made changes to make applications appear * Made changes to make applications appear * Made changes to make applications appear * WIP * #720 Made changes to accommodate unpublished vacancy Co-authored-by: Maria Brookes <maria_brookes@yahoo.co.uk> Co-authored-by: warrensearle <warren.searle@judicialappointments.digital>
joy-ade
pushed a commit
that referenced
this pull request
Aug 10, 2021
* 517 Collect more detailed history of qualifying test responses - Save history - on Exit Modal - on information page - on review - on Situational Judgement - Save session - on skip - on SAve * Disable circleci config * Include CODEOWNERS * digital-platform#305 Include pull request template * Include lint and test in PR workflow * Fix the broken preview URLs and workflow (#752) * Small change to test broken * Preview workflow should use node 10, for now * Update package-lock * Small change to test fixed * test to fix Co-authored-by: Tom Russell <TR115251@hotmail.co.uk> * #729 Fixed errors on Qualifications page (#734) * #729 Fixed errors on Qualifications page * #729 Changes as per PR comments Co-authored-by: Maria Brookes <maria_brookes@yahoo.co.uk> Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> * #708 account creation issues (#751) * Add await into account creation - improve password validation * sort sign-in chronology * add and fix password tests * Add await into account creation - improve password validation * sort sign-in chronology * add and fix password tests * fix signUp test Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> * #720 Added a message if vacancy was unpublished (#732) * #720 Added a message if vacancy was unpublished * #720 Display message if vacancy unpublished * Made changes to make applications appear * Made changes to make applications appear * Made changes to make applications appear * WIP * #720 Made changes to accommodate unpublished vacancy Co-authored-by: Maria Brookes <maria_brookes@yahoo.co.uk> Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> * Update github workflow files * Bump version number to 1.39.0 * Remove circleCI config * Update README.md * Bump version number to 1.40.0 * Update workflows to target staging and production * Bump version number to 1.39.0 * Remove name-blind sift and phone assessment from timeline (#753) * remove name-blind sift and phone assessment from timeline * fix timeline tests * delete commented code Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> * Security/769 weak passwords allowed in reset form (#778) * Reset PW component with proper validation * check for valid action code * #771 Authentication Generic Errors (#775) * Display a generic erorr for wrong password or user not found * Update SignIn.vue replicating changes from local copy due to a 403 error * adding lodash as explicit dependency Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> * #1289 Remove gaps in employment from non-legal exercises (#761) * inital changes * Update readme * remove commented code Co-authored-by: Warren Searle <warren@precise-minds.co.uk> * #1313 Location preferences (#777) * wip * wip * ranked choice changes * remove unrelated changes * remove padding * remove phantom checkbox * add to review page * remove from review page [wrong branch] Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> * Workflow: on merge. Change develop to main branch * Bump version number to 1.40.0 * 517 Collect more detailed history of qualifying test responses - Save history - on Exit Modal - on information page - on review - on Situational Judgement - Save session - on skip - on SAve * [517] fix anlytics * [517] resolve conflict package-lock Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: Warren Searle <warren@precise-minds.co.uk> Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> Co-authored-by: Tom Russell <TR115251@hotmail.co.uk> Co-authored-by: Maria Brookes <40855898+mbrookeswebdev@users.noreply.github.com> Co-authored-by: Maria Brookes <maria_brookes@yahoo.co.uk> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.