Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove name-blind sift and phone assessment from timeline #753

Merged
merged 6 commits into from
May 20, 2021
Merged

Remove name-blind sift and phone assessment from timeline #753

merged 6 commits into from
May 20, 2021

Conversation

tomlovesgithub
Copy link
Contributor

@tomlovesgithub tomlovesgithub commented Apr 16, 2021 •
edited by warrensearle
Loading

Removed timeline items

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@tomlovesgithub tomlovesgithub requested review from a team as code owners April 16, 2021 15:24
@tomlovesgithub tomlovesgithub requested review from lloback, JeremykJAC, mbrookeswebdev and joy-ade and removed request for a team April 16, 2021 15:24
@warrensearle warrensearle requested review from warrensearle and removed request for lloback April 19, 2021 08:13
@github-actions
Copy link

github-actions bot commented Apr 19, 2021 •
edited
Loading

Visit the preview URL for this PR (updated for commit 0a5c356):

https://jac-apply-develop--pr753-750-timeline-items-tz7m3mco.web.app

(expires Fri, 18 Jun 2021 15:53:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

mbrookeswebdev
mbrookeswebdev suggested changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@mbrookeswebdev mbrookeswebdev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joy confirmed on the ticket the specific requirements, so this works as intended. Maybe just remove unwanted code rather than uncomment it.

@mbrookeswebdev mbrookeswebdev self-requested a review April 21, 2021 14:35
@HalcyonJAC HalcyonJAC requested review from HalcyonJAC and removed request for JeremykJAC April 22, 2021 14:02
HalcyonJAC
HalcyonJAC requested changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. The code in the Vue component has been commented out but the code for the unit test has been deleted. I think that either both should be commented our or both deleted...

warrensearle
warrensearle requested changes Apr 26, 2021
View reviewed changes
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomlovesgithub I wonder if we could use the same timeline code in Apply and Admin, just ensure that it checks for data existence before displaying timeline events. (would mean we can move it to JAC Kit)
That way the logic for what shows on Apply vs Admin will be controlled in one place (in digital-platform where we decide which data to publish to Vacancies).

src/helpers/Timeline/exerciseTimeline.js Show resolved Hide resolved
@KateMJAC KateMJAC requested review from KateMJAC and removed request for joy-ade May 4, 2021 12:18
@tomlovesgithub
Copy link
Contributor Author

I'm very supportive of the idea of moving the timeline to JACKIT however i think we should make a separate issue for that as there are some discrepancies in the code and hurdles in terms displaying certain info for admins/applicants.

1 similar comment
@tomlovesgithub
Copy link
Contributor Author

I'm very supportive of the idea of moving the timeline to JACKIT however i think we should make a separate issue for that as there are some discrepancies in the code and hurdles in terms displaying certain info for admins/applicants.

KateMJAC
KateMJAC reviewed May 14, 2021
View reviewed changes
Copy link

@KateMJAC KateMJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a positive result.

This has been sent to UTG. Once I receive feedback, I will update.

lloback
lloback approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@lloback lloback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok. Checked on browser

@warrensearle warrensearle temporarily deployed to develop May 19, 2021 15:50 Inactive
HalcyonJAC
HalcyonJAC approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now :)

KateMJAC
KateMJAC approved these changes May 20, 2021
View reviewed changes
Copy link

@KateMJAC KateMJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Positive user testing result.

@warrensearle warrensearle merged commit eb2af55 into develop May 20, 2021
@warrensearle warrensearle deleted the 750/timeline-items branch May 20, 2021 15:13
lloback pushed a commit that referenced this pull request Jul 20, 2021
@tomlovesgithub @HalcyonJAC @lloback
Remove name-blind sift and phone assessment from timeline (#753)
7932fbc 
* remove name-blind sift and phone assessment from timeline

* fix timeline tests

* delete commented code

Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com>
joy-ade pushed a commit that referenced this pull request Aug 10, 2021
@lloback @warrensearle
@tomlovesgithub @mbrookeswebdev @HalcyonJAC
Apply/517 qt analytics - save History and session time (#774)
d206768 
* 517 Collect more detailed history of qualifying test responses
- Save history
	- on Exit Modal
	- on information page
	- on review
	- on Situational Judgement
- Save session
	- on skip
	- on SAve

* Disable circleci config

* Include CODEOWNERS

* digital-platform#305 Include pull request template

* Include lint and test in PR workflow

* Fix the broken preview URLs and workflow (#752)

* Small change to test broken

* Preview workflow should use node 10, for now

* Update package-lock

* Small change to test fixed

* test to fix

Co-authored-by: Tom Russell <TR115251@hotmail.co.uk>

* #729 Fixed errors on Qualifications page (#734)

* #729 Fixed errors on Qualifications page

* #729 Changes as per PR comments

Co-authored-by: Maria Brookes <maria_brookes@yahoo.co.uk>
Co-authored-by: warrensearle <warren.searle@judicialappointments.digital>

* #708 account creation issues (#751)

* Add await into account creation - improve password validation

* sort sign-in chronology

* add and fix password tests

* Add await into account creation - improve password validation

* sort sign-in chronology

* add and fix password tests

* fix signUp test

Co-authored-by: warrensearle <warren.searle@judicialappointments.digital>

* #720 Added a message if vacancy was unpublished (#732)

* #720 Added a message if vacancy was unpublished

* #720 Display message if vacancy unpublished

* Made changes to make applications appear

* Made changes to make applications appear

* Made changes to make applications appear

* WIP

* #720 Made changes to accommodate unpublished vacancy

Co-authored-by: Maria Brookes <maria_brookes@yahoo.co.uk>
Co-authored-by: warrensearle <warren.searle@judicialappointments.digital>

* Update github workflow files

* Bump version number to 1.39.0

* Remove circleCI config

* Update README.md

* Bump version number to 1.40.0

* Update workflows to target staging and production

* Bump version number to 1.39.0

* Remove name-blind sift and phone assessment from timeline (#753)

* remove name-blind sift and phone assessment from timeline

* fix timeline tests

* delete commented code

Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com>

* Security/769 weak passwords allowed in reset form (#778)

* Reset PW component with proper validation

* check for valid action code

* #771 Authentication Generic Errors (#775)

* Display a generic erorr for wrong password or user not found

* Update SignIn.vue

replicating changes from local copy due to a 403 error

* adding lodash as explicit dependency

Co-authored-by: warrensearle <warren.searle@judicialappointments.digital>

* #1289 Remove gaps in employment from non-legal exercises (#761)

* inital changes

* Update readme

* remove commented code

Co-authored-by: Warren Searle <warren@precise-minds.co.uk>

* #1313 Location preferences (#777)

* wip

* wip

* ranked choice changes

* remove unrelated changes

* remove padding

* remove phantom checkbox

* add to review page

* remove from review page [wrong branch]

Co-authored-by: warrensearle <warren.searle@judicialappointments.digital>

* Workflow: on merge. Change develop to main branch

* Bump version number to 1.40.0

* 517 Collect more detailed history of qualifying test responses
- Save history
	- on Exit Modal
	- on information page
	- on review
	- on Situational Judgement
- Save session
	- on skip
	- on SAve

* [517] fix anlytics

* [517] resolve conflict package-lock

Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>
Co-authored-by: Warren Searle <warren@precise-minds.co.uk>
Co-authored-by: warrensearle <warren.searle@judicialappointments.digital>
Co-authored-by: Tom Russell <TR115251@hotmail.co.uk>
Co-authored-by: Maria Brookes <40855898+mbrookeswebdev@users.noreply.github.com>
Co-authored-by: Maria Brookes <maria_brookes@yahoo.co.uk>
Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com>
Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com>
@andrew-isaac
Copy link

Reopened ticket as there is some issues with this and what a user and candidate experience!

As a user running an exercise around 95% of paper sift exercises are name blind - This is only a few where this is not the case. When a user sets up an exercise they select the "Name Blind Sift" option and input their dates onto a timeline.

The correct order for the timeline of events for a name blind paper sift is:

  • Open for applications

  • Close for applications

  • JAC contacts IAs

  • Return date for IAs

  • Name blind sift

image.png

When this is displayed on the apply side to a candidate it is displayed in the incorrect order with the Name Blind Sift date missing. The list should follow the same order as above and where it has "Name Blind Sift" it should display the month and year for the candidate

image.png
o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalcyonJAC HalcyonJAC HalcyonJAC approved these changes

@KateMJAC KateMJAC KateMJAC approved these changes

@mbrookeswebdev mbrookeswebdev mbrookeswebdev approved these changes

@lloback lloback lloback approved these changes

@warrensearle warrensearle warrensearle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tomlovesgithub @andrew-isaac @warrensearle @lloback @mbrookeswebdev @KateMJAC @HalcyonJAC