#1445 Statement of eligibility fix #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrensearle
requested review from
lloback,
HalcyonJAC,
tomlovesgithub and
joy-ade
and removed request for
lloback
tomlovesgithub
approved these changes
Jul 20, 2021
HalcyonJAC
approved these changes
Jul 20, 2021
tomlovesgithub
added a commit
that referenced
this pull request
Jul 28, 2021
* update application to use new editablefields (#1329) * update application to use new editablefields * use new editablefield component Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> * 1351 character issues (#1352) * Bug Fix - when editing an independent assessor for an application the form fields are not validated at all * Bug Fix - when editing a leadership judge for an application the form fields are not validated at all * Independant Assessments - show invalid email addresses if applicable * Report - Character Issues - Can now optionally filter by stage and status * Report - Character Issues - fixed bug where character info not being present would prevent table data from rendering * Report - Character Issues - removed table search feature as didn't work and is not compatible with status dropdowns anyway * Character Issues - issue summary and details now populated by back-end * use reload() function of Table component * character issues - filter dropdowns are now side-by-side * Revert "Independant Assessments - show invalid email addresses if applicable" This reverts commit 9ba62be. * undo changes accidentally checked into this branch * Fix paging on character issues report * character issues report - removed custom CSS Co-authored-by: Warren Searle <warren@precise-minds.co.uk> * #465 Validate independent assessor details (#1340) * Bug Fix - when editing an independent assessor for an application the form fields are not validated at all * Bug Fix - when editing a leadership judge for an application the form fields are not validated at all * Independant Assessments - show invalid email addresses if applicable * use save(isValid) instead of this.validate() * Fix form validation change - introduced bug. * eligibility issues - renamed filename (#1358) * Events (display logged events) (#1246) * WIP * WIP * Events - hide all details blocks initially * Events - Only allow super admins to view the Events page * Make Halycon a super admin Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> * Enable GitHub Code Scanning (#1339) * Create codeql-analysis.yml * Changed branch from develop to main * [Snyk] Upgrade @ministryofjustice/frontend from 0.0.17-alpha to 0.2.2 (#1334) * fix: upgrade @ministryofjustice/frontend from 0.0.17-alpha to 0.2.2 Snyk has created this PR to upgrade @ministryofjustice/frontend from 0.0.17-alpha to 0.2.2. See this package in npm: https://www.npmjs.com/package/@ministryofjustice/frontend See this project in Snyk: https://app.snyk.io/org/halcyonjac/project/4dc883ab-c3f8-415b-9633-ac68cd41b384?utm_source=github&utm_medium=upgrade-pr * bug fix - tableQuery Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> Co-authored-by: HalyconJAC <halcyon@judicialappointments.digital> * [Snyk] Upgrade @vue/compiler-sfc from 3.0.7 to 3.0.11 (#1335) * fix: upgrade @vue/compiler-sfc from 3.0.7 to 3.0.11 Snyk has created this PR to upgrade @vue/compiler-sfc from 3.0.7 to 3.0.11. See this package in npm: https://www.npmjs.com/package/@vue/compiler-sfc See this project in Snyk: https://app.snyk.io/org/halcyonjac/project/4dc883ab-c3f8-415b-9633-ac68cd41b384?utm_source=github&utm_medium=upgrade-pr * bug fix - tableQuery Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> Co-authored-by: HalyconJAC <halcyon@judicialappointments.digital> * only authorised user can edit * Hotfix/0.65.1 (#1377) * Update auth.js * Added microsoft login * remove check for emailverified * Hide the google log in button until you press Escape * remove .digital wording * lint Co-authored-by: Adam Lewis <halcyon@judicialappointments.digital> * Hotfix/0.65.1 (#1382) * Update auth.js * Added microsoft login * remove check for emailverified * Hide the google log in button until you press Escape * remove .digital wording * lint * bump version number * allow justice.gov.uk * allow select justice.gov access Co-authored-by: Adam Lewis <halcyon@judicialappointments.digital> * #1054 Added a new component to enable change of candidates login address (#1370) * #1054 Added a new component to enable change of candidates login address * #1054 Adjusted margin * #1054 Removed unnecessary component * #1054 Adjusted margin size * #1054 Fixed minor issues with email display * #1054 Status message minor change * #1271 rich text input for ASC (#1292) * RTF on ASC * v-html to show RTF on ASC * v-html for ASC on review pages * v-html for ASC on review pages * address PR comments * resolve merge conflict * point asc titles to vacancy not application Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> * #1324 Made changes to display correct number of days in Full Information view (#1373) * Bump version number to 0.67.0 * #1347 Enable application process to be configured (#1362) * Update readme.md * Move edit forms and improve navigation * Navigation changes * Update navigation * Fix create exercise journey * Only show relevant application parts - Include local filters * Store applicationContent in map instead of array * Update PR workflow * Update package-lock.json * Temporarily turn off tests * Ensure application content stays up to date * Update save application content * Fix some bugs * Make use of exercise store getter methods * #1346 Change exercise state * Only approved exercises should allow state changes * #1347 Enable application content to be assigned to exercise state * Refine function names * Fix backwards compatibility * Refactor to use new exerciseHelper module * Fix exercise helper * Capture current step/stage and dates * Tidy exercise helper * Fix. Timeline. SJ end time not being retained * Update package version * Update readme * Fix missing dependency * Undo change to package-lock * Patch fix tests (#1392) * Display extra pupilage details (#1291) * display pupilage details * only show pupilage notes when necessary * remove unnecessary check * correct pupilage on review page * correct pupilage reveiw * correct pupilage reveiw * show no further details if date provided Co-authored-by: Warren Searle <warren@precise-minds.co.uk> * Hot fix for recommended to handover (#1405) * Bump version number to 0.68.0 * #1399 - repair candidate list on panel packs - sift and selection (#1406) * qt statusLog reset field and modal * fix isSift and isSelection * remove unneeded changes * remove unneeded changes * #1445 Statement of eligibility fix (#1446) * Bump version number to 0.69.0 * #1077 Display responses provided in a previous test (#1379) * 1077 allow the responses to show even when the test haven't started or completed * Update package lock with version on develop * [1077] Display responses provided in a previous test - Deal with edge cases scenario * Reset package-lock so same as main branch Co-authored-by: Warren Searle <warren@precise-minds.co.uk> * Added modals for setting cut off score and updating status of selected applications within the QT report (#1383) Co-authored-by: Adam Lewis <adam@anlewis.co> * Changed IA hard limit time (#1439) * update jac-kit * #730 QT response reset and confirmation modal (#1227) * qt statusLog reset field and modal * modal styling * Bump version number to 0.70.0 * wip * merged-needs test * remove commented code * fix tests Co-authored-by: HalcyonJAC <79906532+HalcyonJAC@users.noreply.github.com> Co-authored-by: Warren Searle <warren@precise-minds.co.uk> Co-authored-by: warrensearle <warren.searle@judicialappointments.digital> Co-authored-by: Snyk bot <github+bot@snyk.io> Co-authored-by: HalyconJAC <halcyon@judicialappointments.digital> Co-authored-by: Maria Brookes <40855898+mbrookeswebdev@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Adam Lewis <adam@anlewis.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Fixes a bug where Statement of Eligibility is being requested when it has not been fully configured. See #1445 for more info.
Note
exerciseHelperfile is identical betweenapplyandadminrepos. It will be moved tojac-kitonce it has been in flight a little longerWho should test?
✅ Developers
How to test?
Please just code review.
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work