#1488 Added access for approved statistitian #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookeswebdev
requested review from
warrensearle,
HalcyonJAC,
tomlovesgithub and
joy-ade
|
Visit the preview URL for this PR (updated for commit 001755b): https://jac-admin-develop--pr1489-feature-1488-enable-hu1icrsj.web.app (expires Fri, 22 Oct 2021 13:43:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
warrensearle
approved these changes
Sep 21, 2021
HalcyonJAC
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
@mbrookeswebdev this looks fine, changes approved, but it has a merge conflict. I hope that fixing this won't cause approvals to be lost...
tomlovesgithub
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Added another email address to the list of approved users.
Who should test?
✅ BA
How to test?
The statistitian should be able to create an account and log in to the platform.
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
PREVIEW:DEVELOP