Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1599 Character Search #1600

Merged
merged 1 commit into from
Apr 5, 2022
Merged

#1599 Character Search #1600

merged 1 commit into from
Apr 5, 2022

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Mar 25, 2022

Author checklist

  • Include primary ticket number in title - e.g. "Show uploaded files in vacancy details page #123 New styling for widget" - and any additional tickets in description
  • Fill in the details below and delete as appropriate
  • Be proactive in getting your work approved 💪

What's included?

Add the character search feature:

  • case-insensitive query
  • fuzzy query

Note: the search keywords will be based on the field computed.search of collection candidates.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

  1. Go to an exercise
  2. Go to Reports and click Character Issues
  3. Type candidate name in search box

Sample test link: https://jac-admin-develop--pr1600-feature-1599-charact-m9ytouyf.web.app/exercise/ws8DOmg9UkBA2KrHnWdl/reports/character-issues

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

jac-admin-character-issues-search

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@HalcyonJAC HalcyonJAC self-assigned this Mar 25, 2022
@HalcyonJAC HalcyonJAC marked this pull request as ready for review March 25, 2022 14:38
@HalcyonJAC HalcyonJAC requested review from a team as code owners March 25, 2022 14:38
@HalcyonJAC HalcyonJAC temporarily deployed to develop March 25, 2022 14:39 Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop March 25, 2022 14:40 Inactive
@github-actions
Copy link

github-actions bot commented Mar 25, 2022

Visit the preview URL for this PR (updated for commit e66f1c9):

https://jac-admin-develop--pr1600-feature-1599-charact-m9ytouyf.web.app

(expires Sun, 24 Apr 2022 14:50:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@HalcyonJAC HalcyonJAC temporarily deployed to develop March 25, 2022 14:47 Inactive
Copy link

@andrew-isaac andrew-isaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, good to see the custom search for candidates works 👍

@warrensearle warrensearle merged commit c912f0c into main Apr 5, 2022
@warrensearle warrensearle deleted the feature/1599-character-search branch April 5, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants